From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zolotarov Subject: Re: [PATCH net-next v1 4/5] ixgbevf: Add RSS Key query code Date: Wed, 31 Dec 2014 19:01:03 +0200 Message-ID: <54A42BCF.8000904@cloudius-systems.com> References: <1420019519-18139-1-git-send-email-vladz@cloudius-systems.com> <1420019519-18139-5-git-send-email-vladz@cloudius-systems.com> <1420043307.31582.53.camel@jtkirshe-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, gleb@cloudius-systems.com, avi@cloudius-systems.com To: Jeff Kirsher Return-path: Received: from mail-wi0-f178.google.com ([209.85.212.178]:35617 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbaLaRBH (ORCPT ); Wed, 31 Dec 2014 12:01:07 -0500 Received: by mail-wi0-f178.google.com with SMTP id em10so25695841wid.17 for ; Wed, 31 Dec 2014 09:01:05 -0800 (PST) In-Reply-To: <1420043307.31582.53.camel@jtkirshe-mobl> Sender: netdev-owner@vger.kernel.org List-ID: On 12/31/14 18:28, Jeff Kirsher wrote: > On Wed, 2014-12-31 at 11:51 +0200, Vlad Zolotarov wrote: >> Signed-off-by: Vlad Zolotarov >> --- >> New in v1 (compared to RFC): >> - Use "if-else" statement instead of a "switch-case" for a single >> option case >> (in ixgbevf_get_rss_key()). >> >> --- >> drivers/net/ethernet/intel/ixgbevf/mbx.h | 2 ++ >> drivers/net/ethernet/intel/ixgbevf/vf.c | 44 >> ++++++++++++++++++++++++++++++++ >> drivers/net/ethernet/intel/ixgbevf/vf.h | 1 + >> 3 files changed, 47 insertions(+) > Just caught this now, sorry but your patch description is sparse (i.e. > non-existent). I know that the title of the patch pretty much tells > what you are doing, but it would be nice to have a bit more detail as to > why (like your first patch). > > Same goes for patch 5 of the series as well. No problema. ;) Will send the v2.