From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y6NXz-0002bT-Jw for qemu-devel@nongnu.org; Wed, 31 Dec 2014 12:59:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y6NXu-0003Az-Ou for qemu-devel@nongnu.org; Wed, 31 Dec 2014 12:59:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y6NXu-00039N-Hw for qemu-devel@nongnu.org; Wed, 31 Dec 2014 12:58:58 -0500 Message-ID: <54A4395D.1040401@redhat.com> Date: Wed, 31 Dec 2014 18:58:53 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1420024880-15416-1-git-send-email-lersek@redhat.com> <54A3F829.4000509@redhat.com> <54A4032A.7050808@redhat.com> <54A423ED.3040606@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu devel list , Paolo Bonzini , Drew Jones , Alexander Graf , Gerd Hoffmann On 12/31/14 18:44, Peter Maydell wrote: > On 31 December 2014 at 17:17, Peter Maydell wrote: >> Unpatched QEMU + QEMU_EFI.fd.v4 : doesn't boot (doesn't load kernel) >> Patched QEMU + QEMU_EFI.fd.v4_noswizzle : boots OK (dracut-initqueue >> starts downloading things). > > Just noticed you asked for the full matrix of tests: > patched QEMU + fd.v4 : doesn't boot (doesn't load kernel) > unpatched + noswizzle : boots OK > > That's a bit confusing... It's not confusing. When you run unpatched qemu *on a big endian host*, that's identical to what the patched code does *on a big endian host*. The full matrix actually has 8 elements (3 dimensions with 2 values per dimension) -- host endianness, patched qemu vs. unpatched qemu, and swizzling vs. non-swizzling firmware. Thanks, Laszlo