From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net ([212.227.15.19]:59289 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbbAANy3 (ORCPT ); Thu, 1 Jan 2015 08:54:29 -0500 Message-ID: <54A5518C.6050107@gmx.de> Date: Thu, 01 Jan 2015 14:54:20 +0100 From: Hartmut Knaack MIME-Version: 1.0 To: Daniel Baluta , jic23@kernel.org CC: lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.pandruvada@linux.intel.com Subject: Re: [PATCH 10/10] iio: imu: kmx61: Use correct base when reading data References: <1419340953-23161-1-git-send-email-daniel.baluta@intel.com> <1419340953-23161-11-git-send-email-daniel.baluta@intel.com> In-Reply-To: <1419340953-23161-11-git-send-email-daniel.baluta@intel.com> Content-Type: text/plain; charset=ISO-8859-15 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org Daniel Baluta schrieb am 23.12.2014 um 14:22: > We have two IIO devices and we need to adjust the base > when reading data. > > Signed-off-by: Daniel Baluta Reviewed-by: Hartmut Knaack > --- > drivers/iio/imu/kmx61.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c > index 98369eb..6178cea 100644 > --- a/drivers/iio/imu/kmx61.c > +++ b/drivers/iio/imu/kmx61.c > @@ -1210,12 +1210,18 @@ static irqreturn_t kmx61_trigger_handler(int irq, void *p) > struct iio_dev *indio_dev = pf->indio_dev; > struct kmx61_data *data = kmx61_get_data(indio_dev); > int bit, ret, i = 0; > + u8 base; > s16 buffer[8]; > > + if (indio_dev == data->acc_indio_dev) > + base = KMX61_ACC_XOUT_L; > + else > + base = KMX61_MAG_XOUT_L; > + > mutex_lock(&data->lock); > for_each_set_bit(bit, indio_dev->buffer->scan_mask, > indio_dev->masklength) { > - ret = kmx61_read_measurement(data, KMX61_ACC_XOUT_L, bit); > + ret = kmx61_read_measurement(data, base, bit); > if (ret < 0) { > mutex_unlock(&data->lock); > goto err; >