From: Chen Gang <gang.chen@sunrus.com.cn>
To: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Cc: linux390@de.ibm.com, holzheu@linux.vnet.ibm.com,
linux-s390@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] s390: include: timex: Use macro CLOCK_STORE_SIZE instead of hard code number
Date: Thu, 01 Jan 2015 22:27:32 +0800 [thread overview]
Message-ID: <54A55954.6000002@sunrus.com.cn> (raw)
For C language, it treats array parameter as a pointer, so sizeof for an
array parameter is equal to sizeof for a pointer, which causes compiler
warning (with allmodconfig by gcc 5):
CC arch/s390/kernel/asm-offsets.s
In file included from include/linux/timex.h:65:0,
from include/linux/sched.h:19,
from include/linux/kvm_host.h:15,
from arch/s390/kernel/asm-offsets.c:10:
./arch/s390/include/asm/timex.h: In function 'get_tod_clock_ext':
./arch/s390/include/asm/timex.h:76:32: warning: 'sizeof' on array function parameter 'clk' will return size of 'char *' [-Wsizeof-array-argument]
typedef struct { char _[sizeof(clk)]; } addrtype;
^
Can use macro CLOCK_STORE_SIZE instead of all related hard code numbers,
which also can avoid this warning. And also add a tab to CLOCK_TICK_RATE
definition to match coding styles.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/s390/hypfs/hypfs_vm.c | 2 +-
arch/s390/include/asm/timex.h | 9 +++++----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/s390/hypfs/hypfs_vm.c b/arch/s390/hypfs/hypfs_vm.c
index 32040ac..344b622 100644
--- a/arch/s390/hypfs/hypfs_vm.c
+++ b/arch/s390/hypfs/hypfs_vm.c
@@ -231,7 +231,7 @@ failed:
struct dbfs_d2fc_hdr {
u64 len; /* Length of d2fc buffer without header */
u16 version; /* Version of header */
- char tod_ext[16]; /* TOD clock for d2fc */
+ char tod_ext[CLOCK_STORE_SIZE]; /* TOD clock for d2fc */
u64 count; /* Number of VM guests in d2fc buffer */
char reserved[30];
} __attribute__ ((packed));
diff --git a/arch/s390/include/asm/timex.h b/arch/s390/include/asm/timex.h
index 8beee1c..2d2fab6 100644
--- a/arch/s390/include/asm/timex.h
+++ b/arch/s390/include/asm/timex.h
@@ -67,20 +67,21 @@ static inline void local_tick_enable(unsigned long long comp)
set_clock_comparator(S390_lowcore.clock_comparator);
}
-#define CLOCK_TICK_RATE 1193180 /* Underlying HZ */
+#define CLOCK_TICK_RATE 1193180 /* Underlying HZ */
+#define CLOCK_STORE_SIZE 16 /* store size for clock */
typedef unsigned long long cycles_t;
-static inline void get_tod_clock_ext(char clk[16])
+static inline void get_tod_clock_ext(char clk[CLOCK_STORE_SIZE])
{
- typedef struct { char _[sizeof(clk)]; } addrtype;
+ typedef struct { char _[CLOCK_STORE_SIZE]; } addrtype;
asm volatile("stcke %0" : "=Q" (*(addrtype *) clk) : : "cc");
}
static inline unsigned long long get_tod_clock(void)
{
- unsigned char clk[16];
+ unsigned char clk[CLOCK_STORE_SIZE];
get_tod_clock_ext(clk);
return *((unsigned long long *)&clk[1]);
}
--
1.7.9.5
next reply other threads:[~2015-01-01 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-01 14:27 Chen Gang [this message]
2015-01-02 9:46 ` [PATCH] s390: include: timex: Use macro CLOCK_STORE_SIZE instead of hard code number Heiko Carstens
2015-01-02 9:46 ` Heiko Carstens
2015-01-03 3:44 ` Chen Gang
2015-01-03 3:44 ` Chen Gang
2015-01-05 8:59 ` Martin Schwidefsky
2015-01-07 14:45 ` Chen Gang S
2015-01-07 15:36 ` Martin Schwidefsky
2015-01-09 21:24 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A55954.6000002@sunrus.com.cn \
--to=gang.chen@sunrus.com.cn \
--cc=heiko.carstens@de.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.