From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y6iPC-0005zu-D4 for qemu-devel@nongnu.org; Thu, 01 Jan 2015 11:15:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y6iP9-0000Xb-8G for qemu-devel@nongnu.org; Thu, 01 Jan 2015 11:15:22 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58772 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y6iP9-0000XP-1j for qemu-devel@nongnu.org; Thu, 01 Jan 2015 11:15:19 -0500 Message-ID: <54A57293.10605@suse.de> Date: Thu, 01 Jan 2015 17:15:15 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1419813550-26182-1-git-send-email-laurent@vivier.eu> <1419813550-26182-4-git-send-email-laurent@vivier.eu> In-Reply-To: <1419813550-26182-4-git-send-email-laurent@vivier.eu> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] qdev'ify dp8393x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: =?ISO-8859-15?Q?Herv=E9_Poussin?= =?ISO-8859-15?Q?eau?= , Leon Alrae , Aurelien Jarno Hi Laurent, Am 29.12.2014 um 01:39 schrieb Laurent Vivier: > Signed-off-by: Laurent Vivier > --- > hw/mips/mips_jazz.c | 2 +- > hw/net/dp8393x.c | 182 +++++++++++++++++++++++++++++++--------= -------- > include/hw/net/dp8393x.h | 1 - > 3 files changed, 121 insertions(+), 64 deletions(-) Thanks for doing this cleanup! "QOM'ify" would be more correct (subject). Patch looks good except for one nit: Can you distinguish between instance_init and realize function rather than using the old SysBusDeviceClass::init? Also, can dp83932_init() be inlined in the call site, or is it used in multiple places? Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)