From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y6jcI-000758-JU for qemu-devel@nongnu.org; Thu, 01 Jan 2015 12:32:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y6jcF-00015Z-Dn for qemu-devel@nongnu.org; Thu, 01 Jan 2015 12:32:58 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:53764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y6jcF-00014Z-42 for qemu-devel@nongnu.org; Thu, 01 Jan 2015 12:32:55 -0500 Message-ID: <54A584A3.2060708@Vivier.EU> Date: Thu, 01 Jan 2015 18:32:19 +0100 From: Laurent Vivier MIME-Version: 1.0 References: <1419813550-26182-1-git-send-email-laurent@vivier.eu> <1419813550-26182-4-git-send-email-laurent@vivier.eu> <54A57293.10605@suse.de> In-Reply-To: <54A57293.10605@suse.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="34hgRS4jGFKAqgeLgULR7ScbMsmDcLwcG" Subject: Re: [Qemu-devel] [PATCH 3/3] qdev'ify dp8393x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Cc: =?ISO-8859-15?Q?Herv=E9_Poussin?= =?ISO-8859-15?Q?eau?= , Leon Alrae , Aurelien Jarno This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --34hgRS4jGFKAqgeLgULR7ScbMsmDcLwcG Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Hi Andreas, Thank you for your comments. You're right: I will change the subject and distinguish the instance_init and realize. dp83932_init() is used in a single place, so as you propose I will inline it and remove the function definition. Regards, Laurent Le 01/01/2015 17:15, Andreas F=E4rber a =E9crit : > Hi Laurent, >=20 > Am 29.12.2014 um 01:39 schrieb Laurent Vivier: >> Signed-off-by: Laurent Vivier >> --- >> hw/mips/mips_jazz.c | 2 +- >> hw/net/dp8393x.c | 182 +++++++++++++++++++++++++++++++-------= --------- >> include/hw/net/dp8393x.h | 1 - >> 3 files changed, 121 insertions(+), 64 deletions(-) >=20 > Thanks for doing this cleanup! "QOM'ify" would be more correct > (subject). Patch looks good except for one nit: Can you distinguish > between instance_init and realize function rather than using the old > SysBusDeviceClass::init? >=20 > Also, can dp83932_init() be inlined in the call site, or is it used in > multiple places? >=20 > Regards, > Andreas >=20 --34hgRS4jGFKAqgeLgULR7ScbMsmDcLwcG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlSlhKQACgkQNKT2yavzbFOBkACfZlhuzUpGSpMiXFWaGWcoRrzk MCgAoKb9kJ3ultspX0vSR9LMwFqZSLJ9 =oZjh -----END PGP SIGNATURE----- --34hgRS4jGFKAqgeLgULR7ScbMsmDcLwcG--