From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1Y6muj-0007JQ-3d
	for qemu-devel@nongnu.org; Thu, 01 Jan 2015 16:04:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1Y6muc-0005bY-Dn
	for qemu-devel@nongnu.org; Thu, 01 Jan 2015 16:04:13 -0500
Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]:40421)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1Y6muc-0005aq-7n
	for qemu-devel@nongnu.org; Thu, 01 Jan 2015 16:04:06 -0500
Message-ID: <54A5B5A0.7000600@reactos.org>
Date: Thu, 01 Jan 2015 22:01:20 +0100
From: =?windows-1252?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1419813550-26182-1-git-send-email-laurent@vivier.eu>
In-Reply-To: <1419813550-26182-1-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 0/3] dp8393x update
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: Leon Alrae <leon.alrae@imgtec.com>, Aurelien Jarno <aurelien@aurel32.net>

Hi Laurent,

Le 29/12/2014 01:39, Laurent Vivier a =E9crit :
> This is a series of patches I wrote to use dp8393x (SONIC) with
> Quadra 800 emulation. I think it is interesting to share them with the
> mainline.
>
> Qdev'ifying allows to remove the annoying warning:
> "requested NIC (anonymous, model dp83932) was not created
>   (not supported by this machine?)"
>
> [PATCH 1/3] dp8393x: add registers offset
> [PATCH 2/3] dp8393x: add PROM to store MAC address
> [PATCH 3/3] qdev'ify dp8393x
>

I also had some patches to QOM'ify dp8393x.
Those are available at http://repo.or.cz/w/qemu/hpoussin.git/shortlog/ref=
s/heads/sonic

Main differences are:
- dp8393x uses an AddressSpace, instead of an offset in a MemoryRegion in=
 yours
- no PROM support, but should be easy to add
- rc4030 (MIPS Jazz chipset) also converted to QOM (but that was not the =
goal of your patch series)

Minor points are:
- have load/save support
- all functions have the same dp8393x_ prefix
- old_mmio-style functions are not used anymore

What do you think of them?

Regards,

Herv=E9