From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y6r9h-0004Th-1n for qemu-devel@nongnu.org; Thu, 01 Jan 2015 20:35:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y6r9d-0008R8-TW for qemu-devel@nongnu.org; Thu, 01 Jan 2015 20:35:57 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:60640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y6r9d-0008Qw-Jc for qemu-devel@nongnu.org; Thu, 01 Jan 2015 20:35:53 -0500 Message-ID: <54A5F5C0.4030402@Vivier.EU> Date: Fri, 02 Jan 2015 02:34:56 +0100 From: Laurent Vivier MIME-Version: 1.0 References: <1419813550-26182-1-git-send-email-laurent@vivier.eu> <54A5B5A0.7000600@reactos.org> In-Reply-To: <54A5B5A0.7000600@reactos.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7cM1QOu9bemE97jjmx0MtTNup5oB0Jelm" Subject: Re: [Qemu-devel] [PATCH 0/3] dp8393x update List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?windows-1252?Q?Herv=E9_Poussineau?= , qemu-devel@nongnu.org Cc: Leon Alrae , Aurelien Jarno This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7cM1QOu9bemE97jjmx0MtTNup5oB0Jelm Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Herv=E9, Le 01/01/2015 22:01, Herv=E9 Poussineau a =E9crit : > Hi Laurent, >=20 > Le 29/12/2014 01:39, Laurent Vivier a =E9crit : >> This is a series of patches I wrote to use dp8393x (SONIC) with >> Quadra 800 emulation. I think it is interesting to share them with the= >> mainline. >> >> Qdev'ifying allows to remove the annoying warning: >> "requested NIC (anonymous, model dp83932) was not created >> (not supported by this machine?)" >> >> [PATCH 1/3] dp8393x: add registers offset >> [PATCH 2/3] dp8393x: add PROM to store MAC address >> [PATCH 3/3] qdev'ify dp8393x >> >=20 > I also had some patches to QOM'ify dp8393x. > Those are available at > http://repo.or.cz/w/qemu/hpoussin.git/shortlog/refs/heads/sonic >=20 > Main differences are: > - dp8393x uses an AddressSpace, instead of an offset in a MemoryRegion > in yours > - no PROM support, but should be easy to add > - rc4030 (MIPS Jazz chipset) also converted to QOM (but that was not th= e > goal of your patch series) >=20 > Minor points are: > - have load/save support > - all functions have the same dp8393x_ prefix > - old_mmio-style functions are not used anymore >=20 > What do you think of them? I don't know if it's a good idea to use AddressSpace into device. For me, AddressSpace must stay in the machine definition. SysBus is there for that. But it seems to be a good way to do DMA. I have to think about that... As I use the dp8393x with a quadra 800 implementation, I don't want to work on rc4030 part, and I need the PROM and the register offset (but as you said it is easy to add). Except for this particular patch I like all the other dp8393x patches. What I propose is to steal these patches (except the QOM one) and include them in my series with the modifications done according comments from Andreas (and perhaps something about the address space, i.e your patch...). Your comments will be welcome. Regards, Laurent --7cM1QOu9bemE97jjmx0MtTNup5oB0Jelm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlSl9cEACgkQNKT2yavzbFPD+QCfR9TiYvETVVbgsDsDSAce3wqW oNIAoLZ7dQXrABik4EzGYc9EnqggURcH =qhM3 -----END PGP SIGNATURE----- --7cM1QOu9bemE97jjmx0MtTNup5oB0Jelm--