All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Cochran <yocto@mindchasers.com>
To: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: linux-qoriq, scmversion: do_configure_prepend() causes error with master...
Date: Thu, 01 Jan 2015 23:15:25 -0500	[thread overview]
Message-ID: <54A61B5D.9010205@mindchasers.com> (raw)

Hi,

Inside linux-qoriq.inc:do_configure_prepend() there is a section that 
builds an scmversion string and writes it to ${S}/.scmversion.

The section of script assumes it's in the source directory and executes 
'git rev-parse --verify --short HEAD' to get the SHA, but this fails and 
the baking abruptly comes to an end.

With a 3.12 kernel, do we need to worry about manually generating an 
scmversion string?  Looking at the default config, LOCALVERSION_AUTO is 
enabled.

However, my generated kernel after I removed the scmversion generation 
logic from do_configure_prepend() didn't show the -gxxxxxxxx suffix when 
I ran uname.  So, it's not clear to me whether this kernel feature is 
broken by the environment.

In summary, I think linux-qoriq.inc needs a patch to 
do_configure_prepend(), but I'm not sure what's actually needed.  In the 
the interim, I'm using a modified linux-qoriq.inc as shown below.

Thanks

Bob


@@ -28,17 +28,6 @@ do_configure_prepend() {
                             ${S}/arch/powerpc/configs/${deltacfg}
                 fi
         done
-
-    #add git revision to the local version
-    if [ "${SCMVERSION}" = "y" ]; then
-            # append sdk version if SDK_VERSION is defined
-            sdkversion=''
-            if [ -n "${SDK_VERSION}" ]; then
-                sdkversion="-${SDK_VERSION}"
-            fi
-            head=`git rev-parse --verify --short HEAD 2> /dev/null`
-            printf "%s%s%s" $sdkversion +g $head > ${S}/.scmversion
-    fi
  }

  # make everything compatible for the time being



             reply	other threads:[~2015-01-02  4:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-02  4:15 Bob Cochran [this message]
2015-01-02 11:40 ` linux-qoriq, scmversion: do_configure_prepend() causes error with master Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A61B5D.9010205@mindchasers.com \
    --to=yocto@mindchasers.com \
    --cc=meta-freescale@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.