From: Larry Finger <Larry.Finger@lwfinger.net>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Joe Perches <joe@perches.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Fix duplicated conditional branch
Date: Sun, 04 Jan 2015 19:40:41 -0600 [thread overview]
Message-ID: <54A9EB99.30806@lwfinger.net> (raw)
In-Reply-To: <1420355446.2619.18.camel@perches.com>
On 01/04/2015 01:10 AM, Joe Perches wrote:
> On Sun, 2015-01-04 at 12:59 +0600, Alexander Kuleshov wrote:
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> []
>> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> []
>> @@ -1661,7 +1661,7 @@ void dm_change_dynamic_initgain_thresh(struct net_device *dev,
>> dm_digtable.rssi_low_thresh = dm_value;
>> } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
>> dm_digtable.rssi_high_power_highthresh = dm_value;
>> - } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
>> + } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW) {
>> dm_digtable.rssi_high_power_highthresh = dm_value;
>> } else if (dm_type == DIG_TYPE_ENABLE) {
>> dm_digtable.dig_state = DM_STA_DIG_MAX;
>
> Presumably, this is a copy/paste error and should have
> both lines changed to HIGHPWR_LOW/high_power_lowthresh
>
> else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW)
> dm_digtable.rssi_high_power_lowthresh = dm_value;
>
I have no idea what this should be, but this patch does not appear to be any
improvement. Joe is probably correct.
Larry
prev parent reply other threads:[~2015-01-05 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 6:59 [PATCH] staging: rtl8192e: Fix duplicated conditional branch Alexander Kuleshov
2015-01-04 7:10 ` Joe Perches
2015-01-05 1:40 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A9EB99.30806@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.