From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/2] cmd_i2c: change variable type for 10bit addressing support
Date: Mon, 05 Jan 2015 06:38:37 +0100 [thread overview]
Message-ID: <54AA235D.8010703@denx.de> (raw)
In-Reply-To: <CAPnjgZ3CyaJXQFUTN8svOBQMces7GMYLUypE4jdecCLwKtxWwA@mail.gmail.com>
Hello Simon,
Am 29.12.2014 22:59, schrieb Simon Glass:
> Hi,
>
> On 19 December 2014 at 14:23, Simon Glass <sjg@chromium.org> wrote:
>> On 19 December 2014 at 11:34, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
>>> To store 10bit chip address, the variable type should not be uchar,
>>> but uint.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>>> Cc: Heiko Schocher <hs@denx.de>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> ---
>>>
>>> common/cmd_i2c.c | 22 +++++++++++-----------
>>> 1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> Acked-by: Simon Glass <sjg@chromium.org>
>
> I feel I should apply this to u-boot-dm as a bug fix, but please let
> me know if there are any objections.
I am fine with that, so:
Acked-by: Heiko Schocher<hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2015-01-05 5:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 18:34 [U-Boot] [RFC PATCH 0/2] This series supports 10bit addressing for driver-model I2C Masahiro Yamada
2014-12-19 18:34 ` [U-Boot] [RFC PATCH 1/2] cmd_i2c: change variable type for 10bit addressing support Masahiro Yamada
2014-12-19 21:23 ` Simon Glass
2014-12-29 21:59 ` Simon Glass
2015-01-05 5:38 ` Heiko Schocher [this message]
2014-12-19 18:34 ` [U-Boot] [RFC PATCH 2/2] dm: i2c: support 10bit addressing in I2C uclass layer Masahiro Yamada
2014-12-19 21:34 ` Simon Glass
2014-12-20 7:25 ` Masahiro YAMADA
2014-12-21 18:53 ` Simon Glass
2014-12-29 22:00 ` Simon Glass
2015-01-05 14:56 ` Masahiro YAMADA
2015-01-06 2:46 ` Simon Glass
2015-01-05 5:39 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AA235D.8010703@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.