From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/4] i2c: UniPhier: add driver for UniPhier i2c controller
Date: Mon, 05 Jan 2015 07:52:24 +0100 [thread overview]
Message-ID: <54AA34A8.3090600@denx.de> (raw)
In-Reply-To: <1419563244-3577-2-git-send-email-yamada.m@jp.panasonic.com>
Hello Masahiro,
Am 26.12.2014 04:07, schrieb Masahiro Yamada:
> This commit adds on-chip I2C driver used on some old Panasonic
> UniPhier SoCs.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Fix a typo. s/freqency/frequency/
> - Add some comments to explain the formula calculating
> wait time.
> - add comments on every register
> - skip stop condition if the next message is read
>
> drivers/i2c/Kconfig | 14 +++
> drivers/i2c/Makefile | 1 +
> drivers/i2c/i2c-uniphier.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 248 insertions(+)
> create mode 100644 drivers/i2c/i2c-uniphier.c
>
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index e69de29..6a479ef 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -0,0 +1,14 @@
> +config DM_I2C
> + bool "Enable Driver Model for I2C drivers"
> + depends on DM
> + help
> + If you want to use driver model for I2C drivers, say Y.
> + To use legacy I2C drivers, say N.
This change seems not related to the "add driver for UniPhier i2c
controller" topic ...
Beside of that, you can add my
Acked-by: Heiko Schocher <hs@denx.de>
to the hole serie. I think this should go to the u-boot-dm tree from
Simon, as it depends on DM changes, or?
Simon? Is this OK for you?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2015-01-05 6:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 3:07 [U-Boot] [PATCH v3 0/4] i2c: UniPhier: add I2C drivers based on driver model Masahiro Yamada
2014-12-26 3:07 ` [U-Boot] [PATCH v3 1/4] i2c: UniPhier: add driver for UniPhier i2c controller Masahiro Yamada
2015-01-05 6:52 ` Heiko Schocher [this message]
2015-01-05 14:35 ` Masahiro YAMADA
2015-01-13 1:29 ` Simon Glass
2014-12-26 3:07 ` [U-Boot] [PATCH v3 2/4] i2c: UniPhier: add driver for UniPhier FIFO-builtin " Masahiro Yamada
2014-12-26 3:07 ` [U-Boot] [PATCH v3 3/4] ARM: UniPhier: enable I2C for UniPhier SoCs Masahiro Yamada
2014-12-26 3:07 ` [U-Boot] [PATCH v3 4/4] ARM: UniPhier: enable CONFIG_I2C_EEPROM Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AA34A8.3090600@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.