Re: [PATCH] btrfs-progs: Fix a extent buffer leak in count_csum_range().

[Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>]

On 2015/01/05 16:56, Qu Wenruo wrote:
> The commit f495a2ac6611 ("btrfs-progs: fsck: remove unfriendly BUG_ON()
> for searching tree failure") is causing tons of extent buffer leak if some
> csum mismatches in btrfsck.
> 
> This is caused by a misplaced btrfs_release_path(), fix it.
> 
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>

Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

> ---
>   cmds-check.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmds-check.c b/cmds-check.c
> index d2d218a..5b644cf 100644
> --- a/cmds-check.c
> +++ b/cmds-check.c
> @@ -1186,9 +1186,9 @@ static int count_csum_range(struct btrfs_root *root, u64 start,
>   		path.slots[0]++;
>   	}
>   out:
> +	btrfs_release_path(&path);
>   	if (ret < 0)
>   		return ret;
> -	btrfs_release_path(&path);
>   	return 0;
>   }
>   
>