From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>, rogerq@ti.com
Cc: linux-can@vger.kernel.org, wsa@the-dreams.de,
linux-omap@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v8 4/8] can: c_can: Add syscon/regmap RAMINIT mechanism
Date: Mon, 5 Jan 2015 11:18:25 +0200 [thread overview]
Message-ID: <54AA56E1.7030105@ti.com> (raw)
In-Reply-To: <1415988591-6032-5-git-send-email-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
Hi Roger,
On 14/11/14 20:09, Marc Kleine-Budde wrote:
> From: Roger Quadros <rogerq@ti.com>
>
> Some TI SoCs like DRA7 have a RAMINIT register specification
> different from the other AMxx SoCs and as expected by the
> existing driver.
>
> To add more insanity, this register is shared with other
> IPs like DSS, PCIe and PWM.
>
> Provides a more generic mechanism to specify the RAMINIT
> register location and START/DONE bit position and use the
> syscon/regmap framework to access the register.
This patch updates the syscon regmap using regmap_read + regmap_write.
That's not a safe way to update the bits, as some other driver may touch
the register between the read and write. The change has to be made using
regmap_update_bits.
We don't have other drivers using the register at the moment, but I
presume we will sooner or later.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-05 9:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 18:09 [PATCH v8 0/8] can: c_can: Use syscon regmap for TI specific RAMINIT register Marc Kleine-Budde
2014-11-14 18:09 ` [PATCH v8 1/8] can: c_can: Add timeout to c_can_hw_raminit_ti() Marc Kleine-Budde
2014-11-14 18:09 ` [PATCH v8 2/8] can: c_can: Introduce c_can_driver_data structure Marc Kleine-Budde
2014-11-14 18:09 ` [PATCH v8 3/8] can: c_can: Add RAMINIT register information to driver data Marc Kleine-Budde
2014-11-14 18:09 ` [PATCH v8 4/8] can: c_can: Add syscon/regmap RAMINIT mechanism Marc Kleine-Budde
2015-01-05 9:18 ` Tomi Valkeinen [this message]
2015-01-07 9:56 ` Roger Quadros
2014-11-14 18:09 ` [PATCH v8 5/8] can: c_can: Add support for START pulse in RAMINIT sequence Marc Kleine-Budde
2014-11-14 18:09 ` [PATCH v8 6/8] can: c_can: Disable pins when CAN interface is down Marc Kleine-Budde
2014-11-14 18:09 ` [PATCH v8 7/8] can: c_can: Add support for TI DRA7 DCAN Marc Kleine-Budde
2014-11-14 18:09 ` [PATCH v8 8/8] can: c_can: Add support for TI am3352 DCAN Marc Kleine-Budde
2014-11-17 12:07 ` [PATCH v8 0/8] can: c_can: Use syscon regmap for TI specific RAMINIT register Roger Quadros
2014-11-17 12:09 ` [PATCH v8 9/9] net: can: c_can: Add support for TI am4372 DCAN Roger Quadros
2014-11-17 12:12 ` Marc Kleine-Budde
2014-11-17 12:31 ` Roger Quadros
2014-11-17 14:19 ` Roger Quadros
2014-11-17 14:31 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AA56E1.7030105@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=rogerq@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.