On 01/04/2015 02:24 PM, Scott Feldman wrote: > On Sun, Jan 4, 2015 at 1:16 PM, Scott Feldman wrote: >> On Fri, Jan 2, 2015 at 3:56 PM, Eric Blake wrote: >>> On 12/29/2014 10:14 PM, sfeldma@gmail.com wrote: >>>> From: Scott Feldman >>> >>> In this mail, I'll review just the QMP interface portion: > > Thanks for review, BTW. > > Question: should these rocker defs be moved to qapi/rocker.json, and > included in top-level qapi-schema.json? Up to you, if you think they are big enough and useful enough to be broken into a separate file. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org