From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yocto@mindchasers.com>
Received: by yocto-www.yoctoproject.org (Postfix, from userid 118)
	id C788BE00751; Mon,  5 Jan 2015 14:21:44 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	yocto-www.yoctoproject.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.1
X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
	*      [score: 0.0000]
Received: from smtp.webfaction.com (mail6.webfaction.com [74.55.86.74])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id 6E227E003E3
	for <meta-freescale@yoctoproject.org>;
	Mon,  5 Jan 2015 14:21:40 -0800 (PST)
Received: from [192.168.1.10] (c-73-194-208-34.hsd1.nj.comcast.net
	[73.194.208.34])
	by smtp.webfaction.com (Postfix) with ESMTP id 9C8002083A60;
	Mon,  5 Jan 2015 22:21:39 +0000 (UTC)
Message-ID: <54AB0E72.1040304@mindchasers.com>
Date: Mon, 05 Jan 2015 17:21:38 -0500
From: Bob Cochran <yocto@mindchasers.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: b40290@freescale.com, meta-freescale@yoctoproject.org
References: <1419303625-6285-1-git-send-email-b40290@freescale.com>
In-Reply-To: <1419303625-6285-1-git-send-email-b40290@freescale.com>
Subject: Re: [meta-fsl-arm][PATCH V3] qe-ucode :add recipes for Layerscape1 support
X-BeenThere: meta-freescale@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Usage and development list for the meta-fsl-* layers
	<meta-freescale.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/meta-freescale>,
	<mailto:meta-freescale-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/meta-freescale>
List-Post: <mailto:meta-freescale@yoctoproject.org>
List-Help: <mailto:meta-freescale-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/meta-freescale>,
	<mailto:meta-freescale-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jan 2015 22:21:44 -0000
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

On 12/22/2014 10:00 PM, b40290@freescale.com wrote:
> From: Chunrong Guo <B40290@freescale.com>
>
>     QE microcode from Freescale is typically provided as a header file.
>     This header file contains macros that define the microcode binary itself as well as
>     some other data used in uploading that microcode


If you're generating a V4 patch, perhaps you'll update these comments, 
too.  I think the text about a header file is stale or at least misleading.


>
> Signed-off-by: Chunrong Guo <B40290@freescale.com>
> ---
>   conf/machine/ls1021aqds.conf         |  2 ++
>   conf/machine/ls1021atwr.conf         |  1 +
>   recipes-bsp/qe-ucode/qe-ucode_git.bb | 27 +++++++++++++++++++++++++++
>   3 files changed, 30 insertions(+)
>   create mode 100644 recipes-bsp/qe-ucode/qe-ucode_git.bb
>
> diff --git a/conf/machine/ls1021aqds.conf b/conf/machine/ls1021aqds.conf
> index d659196..60df6c0 100644
> --- a/conf/machine/ls1021aqds.conf
> +++ b/conf/machine/ls1021aqds.conf
> @@ -15,6 +15,8 @@ UBOOT_CONFIG[qspi] = "ls1021aqds_qspi_config"
>   UBOOT_CONFIG[nor-secboot] = "ls1021aqds_nor_secboot_config"
>   UBOOT_CONFIG[lpuart] = "ls1021aqds_lpuart_config"
>
> +QE_UCODE="iram_Type_A_LS1021a_r1.0.bin"
> +
>   KERNEL_DEVICETREE = "ls1021aqds.dtb"
>
>   SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1 115200;ttyEHV0 115200;ttyLP0"
> diff --git a/conf/machine/ls1021atwr.conf b/conf/machine/ls1021atwr.conf
> index e549ac3..73f222d 100644
> --- a/conf/machine/ls1021atwr.conf
> +++ b/conf/machine/ls1021atwr.conf
> @@ -14,6 +14,7 @@ UBOOT_CONFIG[nor] = "ls1021atwr_nor_config"
>   UBOOT_CONFIG[sdcard] = "ls1021atwr_sdcard_config,sdcard"
>   UBOOT_CONFIG[lpuart] = "ls1021atwr_lpuart_config"
>
> +QE_UCODE="iram_Type_A_LS1021a_r1.0.bin"
>
>   KERNEL_DEVICETREE ?= "ls1021atwr.dtb"
>
> diff --git a/recipes-bsp/qe-ucode/qe-ucode_git.bb b/recipes-bsp/qe-ucode/qe-ucode_git.bb
> new file mode 100644
> index 0000000..02c3119
> --- /dev/null
> +++ b/recipes-bsp/qe-ucode/qe-ucode_git.bb
> @@ -0,0 +1,27 @@
> +DESCRIPTION = "qe microcode binary"
> +SECTION = "qe-ucode"
> +LICENSE = "Freescale-EULA"
> +LIC_FILES_CHKSUM = "file://EULA;md5=60037ccba533a5995e8d1a838d85799c"
> +
> +inherit deploy
> +
> +SRC_URI = "git://git.freescale.com/ppc/sdk/qe-ucode.git;nobranch=1"
> +SRCREV= "49efc94b553de5c2a9bd28093592eff0068e161c"
> +
> +S = "${WORKDIR}/git"
> +
> +do_install () {
> +	install -d ${D}/
> +	install -m 644 ${QE_UCODE} ${D}/
> +}
> +
> +do_deploy () {
> +	install -d ${DEPLOYDIR}/
> +	install -m 644 ${QE_UCODE} ${DEPLOYDIR}/
> +}
> +addtask deploy before do_build after do_install
> +
> +PACKAGES += "${PN}-image"
> +FILES_${PN}-image += "/*"
> +ALLOW_EMPTY_${PN} = "1"
> +
>