From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vince Hsu Subject: Re: [PATCH nouveau 09/11] drm: export some variable and functions to resue the PM functions Date: Tue, 6 Jan 2015 17:36:43 +0800 Message-ID: <54ABACAB.4070209@nvidia.com> References: <1419331204-26679-1-git-send-email-vinceh@nvidia.com> <1419331204-26679-10-git-send-email-vinceh@nvidia.com> <54A20F4D.4040100@gmail.com> <54A2198A.4000707@nvidia.com> <20150105153252.GI12010@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Alexandre Courbot , Thierry Reding Cc: Stephen Warren , "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Emil Velikov , Linux Kernel Mailing List , Ben Skeggs , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Roy Spliet List-Id: linux-tegra@vger.kernel.org T24gMDEvMDYvMjAxNSAwMzo1MCBBTSwgQWxleGFuZHJlIENvdXJib3Qgd3JvdGU6Cj4gT24gTW9u LCBKYW4gNSwgMjAxNSBhdCA0OjMyIFBNLCBUaGllcnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdA Z21haWwuY29tPiB3cm90ZToKPj4gT24gVHVlLCBEZWMgMzAsIDIwMTQgYXQgMTE6MTg6MzRBTSAr MDgwMCwgVmluY2UgSHN1IHdyb3RlOgo+Pj4gSGkgRW1pbCwKPj4+Cj4+PiBPbiAxMi8zMC8yMDE0 IDEwOjM0IEFNLCBFbWlsIFZlbGlrb3Ygd3JvdGU6Cj4+Pj4gT24gMjMvMTIvMTQgMTA6NDAsIFZp bmNlIEhzdSB3cm90ZToKPj4+Pj4gVGhpcyBwYXRjaCBhZGRzIHNvbWUgY2hlY2tzIGluIHRoZSBz dXNwZW5kL3Jlc3VtZSBmdW5jdGlvbnMgdG8gZGlzdGluZ3Vpc2gKPj4+Pj4gdGhlIGRHUFUgYW5k IG1vYmlsZSBHUFUgYW5kIGV4cG9ydHMgc29tZSB2YXJpYWJsZXMvZnVuY3Rpb25zIHNvIHRoYXQg dGhlCj4+Pj4+IG5vdXZlYXUgcGxhdGZvcm0gZGV2aWNlIGNhbiByZXVzZSB0aGVtLgo+Pj4+Pgo+ Pj4+IEhpIFZpbmNlLAo+Pj4+Cj4+Pj4gQWZhaXUgb25lIG5lZWRzIHRvIGV4cG9ydCBhIHN5bWJv bCBhcyBpdCdzIHVzZWQgYnkgYW5vdGhlciBtb2R1bGUgb3IKPj4+PiBzdWJzeXN0ZW0uIFdpdGgg dGhlIGZvbGxvdyB1cCB0d28gcGF0Y2hlcyB5b3UgYXJlIG5vdCBkb2luZyBlaXRoZXIgb25lLAo+ Pj4+IHNvIEknZCBhc3N1bWUgdGhhdCB5b3UgY2FuIGp1c3Qgb21pdCB0aGUgRVhQT1JUXyogY2hh bmdlcy4KPj4+IFRoZSBub3V2ZWF1IHBsYXRmb3JtIGRldmljZSBkcml2ZXIgaXMgYnVpbHQgYXMg YW5vdGhlciBtb2R1bGUgLQo+Pj4gbm91dmVhdV9wbGF0Zm9ybS5rby4gOikKPj4gSSdkIGxpa2Ug dG8gaGVhciB0aGUgb3BpbmlvbiBvZiB0aGUgbm91dmVhdSBwZW9wbGUgYW5kIEFsZXgsIGJ1dCBJ J2QKPj4gdmVyeSBtdWNoIHByZWZlciBpZiBub3V2ZWF1X3BsYXRmb3JtLm8gd2FzIHNpbXBseSBs aW5rZWQgaW50byB0aGUKPj4gbm91dmVhdS5rbyBtb2R1bGUuIEkgZG9uJ3Qgc2VlIGFueSBnb29k IHJlYXNvbiB0byBrZWVwIGl0IHNlcGFyYXRlLgo+IFllcCwgSSBhZ3JlZS4gVGhlIGRlY2lzaW9u IHRvIGhvc3QgcGxhdGZvcm0gc3VwcG9ydCBpbiBhIHNlcGFyYXRlCj4gbW9kdWxlIGxvb2tzIG1p c2xlYWRlZCBpZiBpdCByZXN1bHRzIGluIGFkZGl0aW9uYWwgZXhwb3J0cyB0aGF0IHdlCj4gd291 bGQgb3RoZXJ3aXNlIGF2b2lkLiBJSVVDIEkgZGlkIHRoaXMgdG8gYmUgYWJsZSB0byB1c2UgdGhl IG1vZHVsZQo+IGNvbnZlbmllbmNlIG1hY3JvcyB0byByZWdpc3RlciB0aGUgcGxhdGZvcm0gZHJp dmVyLgo+Cj4+IFNvbWV0aGluZyBsaWtlIHRoZSBhdHRhY2hlZCBwYXRjaCAodW50ZXN0ZWQpIG91 Z2h0IHRvIGRvIGl0Lgo+IFRoaXMgcGF0Y2ggYWxvbmUgd29uJ3QgYmUgZW5vdWdoIGZvciB0aGUg cmVhc29uIEkgbWVudGlvbmVkIGFib3ZlLgo+IEhvd2V2ZXIsIGlmIFZpbmNlIGRvZXNuJ3QgbWlu ZCBoYW5kbGluZyB0aGUgcGxhdGZvcm0gZHJpdmVyCj4gcmVnaXN0cmF0aW9uIG1hbnVhbGx5IGlu IG5vdXZlYXVfZHJtX2luaXQvbm91dmVhdV9kcm1fZXhpdCwgSSBhZ3JlZQo+IHRoaXMgd291bGQg YmUgdGhlIHdheSB0byBnby4KSSBkZWZpbml0ZWx5IGRvbid0IG1pbmQuIDopIFdpbGwgZml4IGlu IG5leHQgdmVyc2lvbiBiYXNlZCBvbiB5b3UgZ3V5cycgCnN1Z2dlc3Rpb25zLgoKVGhhbmtzLApW aW5jZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91 dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754756AbbAFJhL (ORCPT ); Tue, 6 Jan 2015 04:37:11 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:14247 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754640AbbAFJhH (ORCPT ); Tue, 6 Jan 2015 04:37:07 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 06 Jan 2015 01:35:34 -0800 Message-ID: <54ABACAB.4070209@nvidia.com> Date: Tue, 6 Jan 2015 17:36:43 +0800 From: Vince Hsu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Alexandre Courbot , Thierry Reding CC: Emil Velikov , Stephen Warren , Ben Skeggs , Martin Peres , Roy Spliet , , "linux-tegra@vger.kernel.org" , "nouveau@lists.freedesktop.org" , Linux Kernel Mailing List Subject: Re: [Nouveau] [PATCH nouveau 09/11] drm: export some variable and functions to resue the PM functions References: <1419331204-26679-1-git-send-email-vinceh@nvidia.com> <1419331204-26679-10-git-send-email-vinceh@nvidia.com> <54A20F4D.4040100@gmail.com> <54A2198A.4000707@nvidia.com> <20150105153252.GI12010@ulmo.nvidia.com> In-Reply-To: X-Originating-IP: [10.19.108.126] X-ClientProxiedBy: DRBGMAIL103.nvidia.com (10.18.16.22) To HKMAIL101.nvidia.com (10.18.16.10) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2015 03:50 AM, Alexandre Courbot wrote: > On Mon, Jan 5, 2015 at 4:32 PM, Thierry Reding wrote: >> On Tue, Dec 30, 2014 at 11:18:34AM +0800, Vince Hsu wrote: >>> Hi Emil, >>> >>> On 12/30/2014 10:34 AM, Emil Velikov wrote: >>>> On 23/12/14 10:40, Vince Hsu wrote: >>>>> This patch adds some checks in the suspend/resume functions to distinguish >>>>> the dGPU and mobile GPU and exports some variables/functions so that the >>>>> nouveau platform device can reuse them. >>>>> >>>> Hi Vince, >>>> >>>> Afaiu one needs to export a symbol as it's used by another module or >>>> subsystem. With the follow up two patches you are not doing either one, >>>> so I'd assume that you can just omit the EXPORT_* changes. >>> The nouveau platform device driver is built as another module - >>> nouveau_platform.ko. :) >> I'd like to hear the opinion of the nouveau people and Alex, but I'd >> very much prefer if nouveau_platform.o was simply linked into the >> nouveau.ko module. I don't see any good reason to keep it separate. > Yep, I agree. The decision to host platform support in a separate > module looks misleaded if it results in additional exports that we > would otherwise avoid. IIUC I did this to be able to use the module > convenience macros to register the platform driver. > >> Something like the attached patch (untested) ought to do it. > This patch alone won't be enough for the reason I mentioned above. > However, if Vince doesn't mind handling the platform driver > registration manually in nouveau_drm_init/nouveau_drm_exit, I agree > this would be the way to go. I definitely don't mind. :) Will fix in next version based on you guys' suggestions. Thanks, Vince