From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.g.wood@intel.com>
Received: by yocto-www.yoctoproject.org (Postfix, from userid 118)
	id 45C9FE007BA; Tue,  6 Jan 2015 10:49:59 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	yocto-www.yoctoproject.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.1
X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
	*      [score: 0.0000]
	* -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,
	low *      trust
	*      [209.85.212.181 listed in list.dnswl.org]
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
	[209.85.212.181])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id D0826E002F9
	for <toaster@yoctoproject.org>; Tue,  6 Jan 2015 10:49:55 -0800 (PST)
Received: by mail-wi0-f181.google.com with SMTP id r20so62447wiv.14
	for <toaster@yoctoproject.org>; Tue, 06 Jan 2015 10:49:54 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
	:subject:references:in-reply-to:content-type
	:content-transfer-encoding;
	bh=loiCFk3ksOLG1YjyRukBJptDXVewiuAMjocx8FnBr14=;
	b=BR4ax2OPqGe5Lu77kpPYDjUIqvTdpf7H8xk0RMZdYp+I0FSo2zFBI/aLrKc1T4WBnI
	K23bSyXBXg680I0juapiQg4RSun+pw3JMsWamxAAynUlHq2xyNNvE5JO0xMlKqwCHGdj
	Gby380WwvWOqFbupWCpt/RMJt/0yzTAISpjXEVfBCwmmOlqoWZT1V2OzeaRfxmi8Uw0h
	pYSE66J2m3U9m2tzMyhWLGFnayd1CS/O5jO4gCJl3T5MWGpILlnQfDym6KGQKLDkb7J/
	tG1EoIe/MyUMDjtf3tyQCBfreHst7+pLOVaqYFh7hLTGXDIM66U3m88Cf6m0rS+yABQ5
	kG7w==
X-Gm-Message-State: ALoCoQmR+HBYR/+0/GJOxuEd2iXBh0sihQMf3f7+1XABzA/6ACF+MQ3PLDiV1LgDVgTo+OX5DqJh
X-Received: by 10.194.237.101 with SMTP id vb5mr194413412wjc.30.1420570194753; 
	Tue, 06 Jan 2015 10:49:54 -0800 (PST)
Received: from [192.168.2.12] ([83.217.123.106])
	by mx.google.com with ESMTPSA id h13sm14987798wiw.4.2015.01.06.10.49.54
	for <toaster@yoctoproject.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Tue, 06 Jan 2015 10:49:54 -0800 (PST)
Message-ID: <54AC2E51.2060803@intel.com>
Date: Tue, 06 Jan 2015 18:49:53 +0000
From: Michael Wood <michael.g.wood@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: toaster@yoctoproject.org
References: <CAJ2CSBvimUHP3uftbki0WyTwLsHTGYP2TY8mf3JDdibO_RGjYw@mail.gmail.com>
In-Reply-To: <CAJ2CSBvimUHP3uftbki0WyTwLsHTGYP2TY8mf3JDdibO_RGjYw@mail.gmail.com>
Subject: Re: [review-request] adamian/20141216-projectpage-6587
X-BeenThere: toaster@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Web based interface for BitBake <toaster.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/toaster>
List-Post: <mailto:toaster@yoctoproject.org>
List-Help: <mailto:toaster-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jan 2015 18:49:59 -0000
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Code looks ok, would be good to get the "[review-request][PATCH] 
bitbake: toaster: Improve client side error handling" patch in first and 
then make use of that for logging.

Thanks,

Michael


On 06/01/15 16:58, Damian, Alexandru wrote:
> Hello,
>
> I pushed the latest changes to the Project page here.
>
> adamian/20141216-projectpage-6587
>
> This should bring the project page in line with the design, except for 
> error handling in the "invalid machine" and "invalid distro" cases - 
> only "missing target" error handling is present.
>
> Can you please review the code and let me know if I can push ?
>
> Cheers,
> Alex
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>