From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8bxi-0008T5-TJ for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:46:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8bxe-0007wh-Ri for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:46:50 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41980 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8bxe-0007wU-LW for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:46:46 -0500 Message-ID: <54AC57C4.1060400@suse.de> Date: Tue, 06 Jan 2015 22:46:44 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1420550957-22337-1-git-send-email-marcel@redhat.com> <1420550957-22337-2-git-send-email-marcel@redhat.com> In-Reply-To: <1420550957-22337-2-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/6] hw/ppc: modified the condition for usb controllers to be created for some ppc machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mst@redhat.com, lersek@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net On 06.01.15 14:29, Marcel Apfelbaum wrote: > Some ppc machines create a default usb controller based on a 'machine condition'. > Until now the logic was: create the usb controller if: > - the usb option was supplied in cli and value is true or > - the usb option was absent and both set_defaults and the machine > condition were true. > > Modified the logic to: > Create the usb controller if: > - the machine condition is true and defaults are enabled or > - the usb option is supplied and true. > > The main for this is to simplify the usb_enabled method. > > Signed-off-by: Marcel Apfelbaum I think this preserves the logic from a user's perspective quite well. Reviewed-by: Alexander Graf Alex