From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8c4n-0007eW-P3 for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:54:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8c4k-0002FL-3W for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:54:09 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42160 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8c4j-0002FG-Sx for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:54:06 -0500 Message-ID: <54AC597B.3010403@suse.de> Date: Tue, 06 Jan 2015 22:54:03 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1420550957-22337-1-git-send-email-marcel@redhat.com> <54AC3C07.4020307@redhat.com> <54AC4861.1090103@redhat.com> In-Reply-To: <54AC4861.1090103@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Marcel Apfelbaum , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mst@redhat.com, Alexey Kardashevskiy , stefanha@redhat.com, lersek@redhat.com, afaerber@suse.de, rth@twiddle.net On 06.01.15 21:41, Paolo Bonzini wrote: >=20 >=20 > On 06/01/2015 20:48, Paolo Bonzini wrote: >> I like the way you structured the series! >> >> Reviewed-by: Paolo Bonzini >=20 > Hmm, actually doesn't this break -machine usb=3Dno? I think it does, but I don't think we really need to care. We can just assume that the 64bit mac99 always has USB and it's impossible to turn of= f. For sPAPR, we only ever enable USB as convenience option when VGA is enabled. I think it's a pretty fair thing to do there and simply ignore usb=3Dno. If you really need it, just don't use -vga. At the end of the day, I don't think anyone will notice. I'd definitely prefer to keep the code simple. However, I think looking forward we'll want to spawn an XHCI adapter rather than OHCI. It's just a lot cheaper to emulate. But that's out of scope of this patch set. Alex