From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8j7s-0006la-GW for qemu-devel@nongnu.org; Wed, 07 Jan 2015 00:25:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8j7p-0004HZ-6V for qemu-devel@nongnu.org; Wed, 07 Jan 2015 00:25:48 -0500 Received: from mail-we0-x22f.google.com ([2a00:1450:400c:c03::22f]:55014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8j7o-0004HR-VO for qemu-devel@nongnu.org; Wed, 07 Jan 2015 00:25:45 -0500 Received: by mail-we0-f175.google.com with SMTP id k11so503573wes.34 for ; Tue, 06 Jan 2015 21:25:44 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54ACC354.1020405@redhat.com> Date: Wed, 07 Jan 2015 06:25:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1420550957-22337-1-git-send-email-marcel@redhat.com> <54AC3C07.4020307@redhat.com> <54AC4861.1090103@redhat.com> <54AC597B.3010403@suse.de> In-Reply-To: <54AC597B.3010403@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Marcel Apfelbaum , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mst@redhat.com, Alexey Kardashevskiy , stefanha@redhat.com, lersek@redhat.com, afaerber@suse.de, rth@twiddle.net On 06/01/2015 22:54, Alexander Graf wrote: > > > On 06.01.15 21:41, Paolo Bonzini wrote: >> >> >> On 06/01/2015 20:48, Paolo Bonzini wrote: >>> I like the way you structured the series! >>> >>> Reviewed-by: Paolo Bonzini >> >> Hmm, actually doesn't this break -machine usb=no? > > I think it does, but I don't think we really need to care. We can just > assume that the 64bit mac99 always has USB and it's impossible to turn off. > > For sPAPR, we only ever enable USB as convenience option when VGA is > enabled. I think it's a pretty fair thing to do there and simply ignore > usb=no. If you really need it, just don't use -vga. > > At the end of the day, I don't think anyone will notice. I'd definitely > prefer to keep the code simple. Yeah, I agree. If it's hard to fix, this patchset is okay. But if it's not too hard (and I don't think it is, especially if machine_parse is centralized as in my reply to "[PATCH] vl.c: fix regression when reading machine type from config file") the old semantics made more sense. Paolo > However, I think looking forward we'll want to spawn an XHCI adapter > rather than OHCI. It's just a lot cheaper to emulate. But that's out of > scope of this patch set.