Re: [Qemu-devel] [PULL 1/8] cpu: add cpu_physical_memory_clear_dirty_range_nocode

[Paolo Bonzini <pbonzini@redhat.com>]

On 24/12/2014 12:51, Michael S. Tsirkin wrote:
> simple wrapper so callers don't need to know about
> dirty bitmap clients.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  include/exec/ram_addr.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
> index 8fc75cd..18ec092 100644
> --- a/include/exec/ram_addr.h
> +++ b/include/exec/ram_addr.h
> @@ -184,6 +184,14 @@ static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start,
>      bitmap_clear(ram_list.dirty_memory[client], page, end - page);
>  }
>  
> +static inline void cpu_physical_memory_clear_dirty_range_nocode(ram_addr_t start,
> +                                                                ram_addr_t length)
> +{
> +    cpu_physical_memory_clear_dirty_range(start, length, DIRTY_MEMORY_MIGRATION);
> +    cpu_physical_memory_clear_dirty_range(start, length, DIRTY_MEMORY_VGA);
> +}
> +
> +
>  void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t length,
>                                       unsigned client);
>  
> 

The function is not used and goes away in patch 3, so squash it there.

Paolo