From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Date: Wed, 07 Jan 2015 15:17:44 +0800 Message-ID: <54ACDD98.1060305@rock-chips.com> References: <1417760564-16858-1-git-send-email-andy.yan@rock-chips.com> <54AC9C62.3030203@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <54AC9C62.3030203@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Liu Ying , airlied@linux.ie, Philipp Zabel , heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: Mark Rutland , devel@driverdev.osuosl.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , devicetree@vger.kernel.org, Greg Kroah-Hartman , Ian Campbell , Josh Boyer , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Pawel Moll , djkurtz@google.com, ykk@rock-chips.com, Grant Likely , Dave Airlie , Kumar Gala , jay.xu@rock-chips.com, vladimir_zapolskiy@mentor.com, mark.yao@rock-chips.com List-Id: devicetree@vger.kernel.org SGkgTGl1IFlpbmcgLCBQaGlsaXBwOgoKT24gMjAxNeW5tDAx5pyIMDfml6UgMTA6MzksIExpdSBZ aW5nIHdyb3RlOgo+Cj4gT24gMTIvMDUvMjAxNCAwMjoyMiBQTSwgQW5keSBZYW4gd3JvdGU6Cj4+ Cj4+IFdlIGZvdW5kIEZyZWVzY2FsZSBpbXg2IGFuZCBSb2NrY2hpcCByazMyODggYW5kIEluZ2Vu aWMgSlo0NzgwIAo+PiAoWGJ1cnN0L01JUFMpCj4+IHVzZSB0aGUgaW50ZXJmYWNlIGNvbXBhdGli bGUgRGVzaWdud2FyZSBIRE1JIElQLCBidXQgdGhleSBhbHNvIGhhdmUgc29tZQo+PiBsaWdodGx5 IGRpZmZlcmVuY2VzLCBzdWNoIGFzIHBoeSBwbGwgY29uZmlndXJhdGlvbiwgcmVnaXN0ZXIgCj4+ IHdpZHRoKGlteCBoZG1pCj4+IHJlZ2lzdGVyIGlzIG9uZSBieXRlLCBidXQgcmszMjg4IGlzIDQg Ynl0ZXMgd2lkdGggYW5kIGNhbiBvbmx5IGJlIAo+PiBhY2Nlc3NlZAo+PiBieSB3b3JkKSwgNEsg c3VwcG9ydChpbXg2IGRvZXNuJ3Qgc3VwcG9ydCA0aywgYnV0IHJrMzI4OCBkb2VzKSwgYW5kIAo+ PiBIRE1JMi4wCj4+IHN1cHBvcnQuCj4+Cj4+IFRvIHJldXNlIHRoZSBpbXgtaGRtaSBkcml2ZXIs IHdlIG1ha2UgdGhpcyBwYXRjaCBzZXQ6Cj4+ICgxKTogZml4IHNvbWUgQ29kaW5nU3R5bGUgd2Fy bmluZyB0byBtYWtlIGNoZWNrcGF0Y2ggaGFwcHkKPj4gKDIpOiBjb252ZXJ0IGlteC1oZG1pIHRv IGRybV9icmlkZ2UKPj4gKDMpOiBzcGxpdCBwbGF0Zm9ybSBzcGVjaWZpYyBjb2RlCj4+ICg0KTog bW92ZSBpbXgtaGRtaSB0byBicmlkZ2UvZHdfaGRtaQo+PiAoNSk6IGV4dGVuZCBkd19oZG1pLmMg dG8gc3VwcG9ydCByazMyODggaGRtaQo+PiAoNik6IGFkZCByb2NrY2hpcCByazMyODggcGxhdGZv cm0gc3BlY2lmaWMgY29kZSBkd19oZG1pLXJvY2tjaGlwLmMKPj4KPj4gQ2hhbmdlcyBpbiB2MTg6 Cj4+IC0gcmVtb3ZlIGEgbXVsdGlwbGUgYmxhbmsgbGluZXMgaW4gaW14LWhkbWkuYwo+PiAtIGZp eCBhIGNoZWNrcGF0Y2ggd2FybmluZyBpbiBpbXgtaGRtaV9wbHRmbS5jCj4+IC0gYWRkIHBvcnQg YmluZGluZ3MKPj4gLSBjb3JyZWN0IHNvbWUgc3BlbGxpbmcgbWlzdGFrZXMgaW4gZHdfaGRtaSBi aW5kaW5ncyBkb2MKPj4gLSBjb3JyZWN0IHNvbWUgc3BlbGxpbmcgbWlzdGFrZXMgaW4gZHdfaGRt aS1yb2NrY2hpcCBiaW5kaW5ncyBkb2MKPj4KPj4gQ2hhbmdlcyBpbiB2MTc6Cj4+IC0gcmVtb3Zl IHBsYXRmb3JtIGRldmljZSBzdHVmZiwgYWR2aWNlZCBieSBSdXNzZWxsIEtpbmcKPj4gLSByZW1v dmUgcHJvbXB0IG1lc3NhZ2Ugb2YgZHdfaGRtaSwgYWR2aWNlZCBieSBSdXNzZWwgS2luZwo+PiAt IHBhcnNlIHJlc291cmNlIGFuZCBpcnEgaW4gcGxhdGZvcm0gZHJpdmVyCj4+Cj4+IENoYW5nZXMg aW4gdjE2Ogo+PiAtIHVzZSB0aGUgY29tbW9uIGJpbmRpbmcgZm9yIHRoZSBjbG9ja3MKPj4gLSBk ZXNjcmliZSBkZGMtaTJjLWJ1cyBhcyBvcHRpb25hbAo+PiAtIGFkZCBjb21tb24gY2xvY2tzIGJp bmRpbmdzCj4+IC0gbW9kaWZ5IGNsb2NrcyBiaW5kaW5ncwo+PiAtIGRlc2NyYmllIGRkYy1pMmMt YnVzIGFzIG9wdGlvbmFsCj4+Cj4+IENoYW5nZXMgaW4gdjE1Ogo+PiAtIGFkZCBwcmVmaXggZHdf aGRtaS9EV19IRE1JIGZvciBwdWJsaWMgdXNlZCBkd19oZG1pIHN0cnVjdHMKPj4gICAgYWR2aWNl ZCBieSBQaGlsaXBwIFphYmVsCj4+IC0gcmVtb3ZlIFRISVNfTU9EVUxFIGluIHBsYXRmb3JtIGRy aXZlcgo+PiAtIHJlbW92ZSB1bmlvIG9mIHRoZSBtdWx0aS1ieXRlIHJlZ2lzdGVyIGFjY2Vzcywg YWR2aWNlZCBieSBQaGlsaXBwIAo+PiBaYWJlbAo+PiAtIHJlbW92ZSBUSElTX01PRFVMRSBpbiBw bGF0Zm9ybSBkcml2ZXIKPj4KPj4gQ2hhbmdlcyBpbiB2MTQ6Cj4+IC0gYWRkIGRlZmVyIHByb2Jp bmcsIGFkdmljZWQgYnkgUGhpbGlwcCBaYWJlbAo+PiAtIHJlbW92ZSBkcm1fY29ubmVjdG9yX3Jl Z2lzdGVyLCBiZWNhdXNlIGlteC1kcm0gY29yZSBoYXMgcmVnaXN0ZXJlZAo+PiBjb25uZWN0b3IK Pj4KPj4gQ2hhbmdlcyBpbiB2MTM6Cj4+IC0gcGF0Y2ggYWdhaW5zdCBkcm0tbmV4dAo+PiAtIHNw bGl0IHBsYXRmb3JtIHNwZWNpZmljIHBoeSBjb25maWd1cmF0aW9uCj4+IC0gc3BsaXQgcGh5IGNv bmZpZ3VyYXRpb24gZnJvbSBwYXRjaCM0Cj4+Cj4+IENoYW5nZXMgaW4gdjEyOgo+PiAtIHJlZmFj dG9yIG9mX25vZGVfcHV0KGRkY19ub2RlKQo+PiAtIHNxdWFzaCBwYXRjaCA8Y29udmVydCBkd19o ZG1pIHRvIGRybV9icmlkZ2U+Cj4+IC0gYWRkIGNvbW1lbnQgZm9yIHRoZSBkZXBlbmQgb24gcGF0 Y2gKPj4KPj4gQ2hhbmdlcyBpbiB2MTE6Cj4+IC0gc3F1YXNoIHBhdGNoICA8c3BsaXQgc29tZSBw aHkgY29uZmlndXJhdGlvbiB0byBwbGF0Zm9ybSBkcml2ZXI+Cj4+Cj4+IENoYW5nZXMgaW4gdjEw Ogo+PiAtIHNwbGl0IGdlbmVyaWMgZHdfaGRtaS5jIGltcHJvdmVtZW50cyBmcm9tIHBhdGNoIzEx IChhZGQgcmszMjg4IAo+PiBzdXBwb3J0KQo+PiAtIGFkZCBtb3JlIGRpc3BsYXkgbW9kZSBzdXBw b3J0IG1wbGwgY29uZmlndXJhdGlvbiBmb3IgcmszMjg4Cj4+Cj4+IENoYW5nZXMgaW4gdjk6Cj4+ IC0gbW92ZSBzb21lIHBoeSBjb25maWd1cmF0aW9uIHRvIHBsYXRmb3JtIGRyaXZlcgo+Pgo+PiBD aGFuZ2VzIGluIHY4Ogo+PiAtIGNvcnJlY3Qgc29tZSBzcGVsbGluZyBtaXN0YWtlCj4+IC0gbW9k aWZ5IGRkYy1pMmMtYnVzIGFuZCBpbnRlcnJ1cHQgZGVzY3JpcHRpb24KPj4gLSBBZGQgZG9jdW1l bnRhdGlvbiBmb3Igcm9ja2NoaXAgZHcgaGRtaQo+Pgo+PiBDaGFuZ2VzIGluIHY3Ogo+PiAtIHJl bW92ZSB1bnVzZWQgdmFyaWFibGVzIGZyb20gc3RydWN0dXJlIGR3X2hkbWkKPj4gLSByZW1vdmUg YSB3cm9uZyBtb2RpZmljYXRpb24KPj4gLSBhZGQgY29weXJpZ2h0cyBmb3IgZHdfaGRtaS1pbXgu Ywo+Pgo+PiBDaGFuZ2VzIGluIHY2Ogo+PiAtIHJlYXJyYW5nZSB0aGUgcGF0Y2ggb3JkZXIKPj4g LSByZWZhY3RvciByZWdpc3RlciBhY2Nlc3Mgd2l0aG91dCByZWdfc2hpZnQKPj4KPj4gQ2hhbmdl cyBpbiB2NToKPj4gLSByZWZhY3RvciByZWctaW8td2lkdGgKPj4KPj4gQ2hhbmdlcyBpbiB2NDoK Pj4gLSBmaXggY2hlY2twYXRjaCBDSEVDSwo+PiAtIGRlZmVyIHByb2JlIGRkYyBpMmMgYWRhcHRl cgo+Pgo+PiBDaGFuZ2VzIGluIHYzOgo+PiAtIHNwbGl0IG11bHRpLXJlZ2lzdGVyIGFjY2VzcyB0 byBvbmUgaW5kZXBlbnQgcGF0Y2gKPj4KPj4gQW5keSBZYW4gKDEyKToKPj4gICAgZHJtOiBpbXg6 IGlteC1oZG1pOiBtYWtlIGNoZWNrcGF0Y2ggaGFwcHkKPj4gICAgZHJtOiBpbXg6IGlteC1oZG1p OiByZXR1cm4gZGVmZXIgaWYgY2FuJ3QgZ2V0IGRkYyBpMmMgYWRhcHRlcgo+PiAgICBkcm06IGlt eDogaW14LWhkbWk6IGNvbnZlcnQgaW14LWhkbWkgdG8gZHJtX2JyaWRnZSBtb2RlCj4+ICAgIGRy bTogaW14OiBpbXgtaGRtaTogc3BsaXQgcGh5IGNvbmZpZ3VyYXRpb24gdG8gcGxhdGZvcm0gZHJp dmVyCj4+ICAgIGRybTogaW14OiBpbXgtaGRtaTogbW92ZSBpbXgtaGRtaSB0byBicmlkZ2UvZHdf aGRtaQo+PiAgICBkdC1iaW5kaW5nczogYWRkIGRvY3VtZW50IGZvciBkd19oZG1pCj4+ICAgIGRy bTogYnJpZGdlL2R3X2hkbWk6IGFkZCBzdXBwb3J0IGZvciBtdWx0aS1ieXRlIHJlZ2lzdGVyIHdp ZHRoIGFjY2Vzcwo+PiAgICBkcm06IGJyaWRnZS9kd19oZG1pOiBhZGQgbW9kZV92YWxpZCBzdXBw b3J0Cj4+ICAgIGRybTogYnJpZGdlL2R3X2hkbWk6IGNsZWFyIGkyY21waHlfc3RhdDAgcmVnIGlu IAo+PiBoZG1pX3BoeV93YWl0X2kyY19kb25lCj4+ICAgIGRybTogYnJpZGdlL2R3X2hkbWk6IGFk ZCBmdW5jdGlvbiBkd19oZG1pX3BoeV9lbmFibGVfc3BhcmUKPj4gICAgZHQtYmluZGluZ3M6IEFk ZCBkb2N1bWVudGF0aW9uIGZvciByb2NrY2hpcCBkdyBoZG1pCj4+ICAgIGRybTogYnJpZGdlL2R3 X2hkbWk6IGFkZCByb2NrY2hpcCByazMyODggc3VwcG9ydAo+Pgo+PiAgIC4uLi9kZXZpY2V0cmVl L2JpbmRpbmdzL2RybS9icmlkZ2UvZHdfaGRtaS50eHQgICAgIHwgIDUwICsrCj4+ICAgLi4uL2Rl dmljZXRyZWUvYmluZGluZ3MvdmlkZW8vZHdfaGRtaS1yb2NrY2hpcC50eHQgfCAgNDYgKysKPj4g ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL0tjb25maWcgICAgICAgICAgICAgICAgICAgICB8ICAg NSArCj4+ICAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9NYWtlZmlsZSAgICAgICAgICAgICAgICAg ICAgfCAgIDEgKwo+PiAgIC4uLi9ncHUvZHJtL3tpbXgvaW14LWhkbWkuYyA9PiBicmlkZ2UvZHdf aGRtaS5jfSAgIHwgNzE3IAo+PiArKysrKysrKysrLS0tLS0tLS0tLS0KPj4gICAuLi4vZ3B1L2Ry bS97aW14L2lteC1oZG1pLmggPT4gYnJpZGdlL2R3X2hkbWkuaH0gICB8ICAgNCArLQo+PiAgIGRy aXZlcnMvZ3B1L2RybS9pbXgvS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxICsK Pj4gICBkcml2ZXJzL2dwdS9kcm0vaW14L01ha2VmaWxlICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMiArLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pbXgvZHdfaGRtaS1pbXguYyAgICAgICAgICAg ICAgICAgIHwgMjU4ICsrKysrKysrCj4+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL0tjb25m aWcgICAgICAgICAgICAgICAgICAgfCAgMTAgKwo+PiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9NYWtlZmlsZSAgICAgICAgICAgICAgICAgIHwgICAyICsKPj4gICBkcml2ZXJzL2dwdS9kcm0v cm9ja2NoaXAvZHdfaGRtaS1yb2NrY2hpcC5jICAgICAgICB8IDM0MSArKysrKysrKysrCj4+ICAg aW5jbHVkZS9kcm0vYnJpZGdlL2R3X2hkbWkuaCAgICAgICAgICAgICAgICAgICAgICAgfCAgNjEg KysKPj4gICAxMyBmaWxlcyBjaGFuZ2VkLCAxMTExIGluc2VydGlvbnMoKyksIDM4NyBkZWxldGlv bnMoLSkKPj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgCj4+IERvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3X2hkbWkudHh0Cj4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0 IAo+PiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdmlkZW8vZHdfaGRtaS1yb2Nr Y2hpcC50eHQKPj4gICByZW5hbWUgZHJpdmVycy9ncHUvZHJtL3tpbXgvaW14LWhkbWkuYyA9PiBi cmlkZ2UvZHdfaGRtaS5jfSAoNzIlKQo+PiAgIHJlbmFtZSBkcml2ZXJzL2dwdS9kcm0ve2lteC9p bXgtaGRtaS5oID0+IGJyaWRnZS9kd19oZG1pLmh9ICg5OSUpCj4+ICAgY3JlYXRlIG1vZGUgMTAw NjQ0IGRyaXZlcnMvZ3B1L2RybS9pbXgvZHdfaGRtaS1pbXguYwo+PiAgIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHdfaGRtaS1yb2NrY2hpcC5jCj4+ICAgY3Jl YXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvZHJtL2JyaWRnZS9kd19oZG1pLmgKPj4KPgo+IEFmdGVy IGFwcGx5aW5nIHRoaXMgc2VyaWVzLCBJIGZpbmQgdGhlcmUgaXMgYSBidWlsZCBicmVhayBpc3N1 ZSB3aXRoIHRoZQo+IGFsbG1vZGNvbmZpZyBjb25maWd1cmF0aW9uIGZvciB0aGUgQVJNIGFyY2hp dGVjdHVyZS4KPiBQbGVhc2UgZml4IHRoaXMuCj4KPiBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAv ZHdfaGRtaS1yb2NrY2hpcC5jOjI0MzoxOiBlcnJvcjogCj4g4oCYX19tb2Rfb2ZfX2R3X2hkbWlf cm9ja2NoaXBfZHRfaWRzX2RldmljZV90YWJsZeKAmSBhbGlhc2VkIHRvIHVuZGVmaW5lZCAKPiBz eW1ib2wg4oCYZHdfaGRtaV9yb2NrY2hpcF9kdF9pZHPigJkKPiBzY3JpcHRzL01ha2VmaWxlLmJ1 aWxkOjI1NzogcmVjaXBlIGZvciB0YXJnZXQgCj4gJ2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9k d19oZG1pLXJvY2tjaGlwLm8nIGZhaWxlZAo+IG1ha2VbNF06ICoqKiBbZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL2R3X2hkbWktcm9ja2NoaXAub10gRXJyb3IgMQo+IHNjcmlwdHMvTWFrZWZpbGUu YnVpbGQ6NDAyOiByZWNpcGUgZm9yIHRhcmdldCAKPiAnZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlw JyBmYWlsZWQKPiBtYWtlWzNdOiAqKiogW2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcF0gRXJyb3Ig Mgo+IHNjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6NDAyOiByZWNpcGUgZm9yIHRhcmdldCAnZHJpdmVy cy9ncHUvZHJtJyBmYWlsZWQKPiBtYWtlWzJdOiAqKiogW2RyaXZlcnMvZ3B1L2RybV0gRXJyb3Ig Mgo+IHNjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6NDAyOiByZWNpcGUgZm9yIHRhcmdldCAnZHJpdmVy cy9ncHUnIGZhaWxlZAo+IG1ha2VbMV06ICoqKiBbZHJpdmVycy9ncHVdIEVycm9yIDIKPiBNYWtl ZmlsZTo5Mzc6IHJlY2lwZSBmb3IgdGFyZ2V0ICdkcml2ZXJzJyBmYWlsZWQKPiBtYWtlOiAqKiog W2RyaXZlcnNdIEVycm9yIDIKPgo+IFJlZ2FyZHMsCj4gTGl1IFlpbmcKPgo+Cj4KICBWZXJ5IHNv cnJ5IGZvciB0aGVzZSBpc3N1ZSwgdGhhbmsgeW91IGZvciBwb2ludGluZyBvdXQgaXQuCiAgSSB3 aWxsIHNlbmQgW1BBVENIIFYxOC4xIDEyLzEyXSBmb3IgYSBmaXguCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBsaXN0CmRldmVs QGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRyaXZlcnByb2pl Y3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754110AbbAGHR4 (ORCPT ); Wed, 7 Jan 2015 02:17:56 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:57690 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbbAGHRy (ORCPT ); Wed, 7 Jan 2015 02:17:54 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: vladimir_zapolskiy@mentor.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <64b3f2961f92bc356e6ed8f211de1b20> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54ACDD98.1060305@rock-chips.com> Date: Wed, 07 Jan 2015 15:17:44 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Liu Ying , airlied@linux.ie, Philipp Zabel , heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk CC: Mark Rutland , dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Pawel Moll , Ian Campbell , Rob Herring , mark.yao@rock-chips.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , vladimir_zapolskiy@mentor.com Subject: Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi References: <1417760564-16858-1-git-send-email-andy.yan@rock-chips.com> <54AC9C62.3030203@freescale.com> In-Reply-To: <54AC9C62.3030203@freescale.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liu Ying , Philipp: On 2015年01月07日 10:39, Liu Ying wrote: > > On 12/05/2014 02:22 PM, Andy Yan wrote: >> >> We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 >> (Xburst/MIPS) >> use the interface compatible Designware HDMI IP, but they also have some >> lightly differences, such as phy pll configuration, register >> width(imx hdmi >> register is one byte, but rk3288 is 4 bytes width and can only be >> accessed >> by word), 4K support(imx6 doesn't support 4k, but rk3288 does), and >> HDMI2.0 >> support. >> >> To reuse the imx-hdmi driver, we make this patch set: >> (1): fix some CodingStyle warning to make checkpatch happy >> (2): convert imx-hdmi to drm_bridge >> (3): split platform specific code >> (4): move imx-hdmi to bridge/dw_hdmi >> (5): extend dw_hdmi.c to support rk3288 hdmi >> (6): add rockchip rk3288 platform specific code dw_hdmi-rockchip.c >> >> Changes in v18: >> - remove a multiple blank lines in imx-hdmi.c >> - fix a checkpatch warning in imx-hdmi_pltfm.c >> - add port bindings >> - correct some spelling mistakes in dw_hdmi bindings doc >> - correct some spelling mistakes in dw_hdmi-rockchip bindings doc >> >> Changes in v17: >> - remove platform device stuff, adviced by Russell King >> - remove prompt message of dw_hdmi, adviced by Russel King >> - parse resource and irq in platform driver >> >> Changes in v16: >> - use the common binding for the clocks >> - describe ddc-i2c-bus as optional >> - add common clocks bindings >> - modify clocks bindings >> - descrbie ddc-i2c-bus as optional >> >> Changes in v15: >> - add prefix dw_hdmi/DW_HDMI for public used dw_hdmi structs >> adviced by Philipp Zabel >> - remove THIS_MODULE in platform driver >> - remove unio of the multi-byte register access, adviced by Philipp >> Zabel >> - remove THIS_MODULE in platform driver >> >> Changes in v14: >> - add defer probing, adviced by Philipp Zabel >> - remove drm_connector_register, because imx-drm core has registered >> connector >> >> Changes in v13: >> - patch against drm-next >> - split platform specific phy configuration >> - split phy configuration from patch#4 >> >> Changes in v12: >> - refactor of_node_put(ddc_node) >> - squash patch >> - add comment for the depend on patch >> >> Changes in v11: >> - squash patch >> >> Changes in v10: >> - split generic dw_hdmi.c improvements from patch#11 (add rk3288 >> support) >> - add more display mode support mpll configuration for rk3288 >> >> Changes in v9: >> - move some phy configuration to platform driver >> >> Changes in v8: >> - correct some spelling mistake >> - modify ddc-i2c-bus and interrupt description >> - Add documentation for rockchip dw hdmi >> >> Changes in v7: >> - remove unused variables from structure dw_hdmi >> - remove a wrong modification >> - add copyrights for dw_hdmi-imx.c >> >> Changes in v6: >> - rearrange the patch order >> - refactor register access without reg_shift >> >> Changes in v5: >> - refactor reg-io-width >> >> Changes in v4: >> - fix checkpatch CHECK >> - defer probe ddc i2c adapter >> >> Changes in v3: >> - split multi-register access to one indepent patch >> >> Andy Yan (12): >> drm: imx: imx-hdmi: make checkpatch happy >> drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter >> drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode >> drm: imx: imx-hdmi: split phy configuration to platform driver >> drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi >> dt-bindings: add document for dw_hdmi >> drm: bridge/dw_hdmi: add support for multi-byte register width access >> drm: bridge/dw_hdmi: add mode_valid support >> drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in >> hdmi_phy_wait_i2c_done >> drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare >> dt-bindings: Add documentation for rockchip dw hdmi >> drm: bridge/dw_hdmi: add rockchip rk3288 support >> >> .../devicetree/bindings/drm/bridge/dw_hdmi.txt | 50 ++ >> .../devicetree/bindings/video/dw_hdmi-rockchip.txt | 46 ++ >> drivers/gpu/drm/bridge/Kconfig | 5 + >> drivers/gpu/drm/bridge/Makefile | 1 + >> .../gpu/drm/{imx/imx-hdmi.c => bridge/dw_hdmi.c} | 717 >> ++++++++++----------- >> .../gpu/drm/{imx/imx-hdmi.h => bridge/dw_hdmi.h} | 4 +- >> drivers/gpu/drm/imx/Kconfig | 1 + >> drivers/gpu/drm/imx/Makefile | 2 +- >> drivers/gpu/drm/imx/dw_hdmi-imx.c | 258 ++++++++ >> drivers/gpu/drm/rockchip/Kconfig | 10 + >> drivers/gpu/drm/rockchip/Makefile | 2 + >> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 341 ++++++++++ >> include/drm/bridge/dw_hdmi.h | 61 ++ >> 13 files changed, 1111 insertions(+), 387 deletions(-) >> create mode 100644 >> Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >> create mode 100644 >> Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt >> rename drivers/gpu/drm/{imx/imx-hdmi.c => bridge/dw_hdmi.c} (72%) >> rename drivers/gpu/drm/{imx/imx-hdmi.h => bridge/dw_hdmi.h} (99%) >> create mode 100644 drivers/gpu/drm/imx/dw_hdmi-imx.c >> create mode 100644 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >> create mode 100644 include/drm/bridge/dw_hdmi.h >> > > After applying this series, I find there is a build break issue with the > allmodconfig configuration for the ARM architecture. > Please fix this. > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:243:1: error: > ‘__mod_of__dw_hdmi_rockchip_dt_ids_device_table’ aliased to undefined > symbol ‘dw_hdmi_rockchip_dt_ids’ > scripts/Makefile.build:257: recipe for target > 'drivers/gpu/drm/rockchip/dw_hdmi-rockchip.o' failed > make[4]: *** [drivers/gpu/drm/rockchip/dw_hdmi-rockchip.o] Error 1 > scripts/Makefile.build:402: recipe for target > 'drivers/gpu/drm/rockchip' failed > make[3]: *** [drivers/gpu/drm/rockchip] Error 2 > scripts/Makefile.build:402: recipe for target 'drivers/gpu/drm' failed > make[2]: *** [drivers/gpu/drm] Error 2 > scripts/Makefile.build:402: recipe for target 'drivers/gpu' failed > make[1]: *** [drivers/gpu] Error 2 > Makefile:937: recipe for target 'drivers' failed > make: *** [drivers] Error 2 > > Regards, > Liu Ying > > > Very sorry for these issue, thank you for pointing out it. I will send [PATCH V18.1 12/12] for a fix.