Re: [PATCH stable] can_dev: fix crtlmode_supported check

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On 01/05/2015 06:40 PM, Oliver Hartkopp wrote:
> When changing flags in the CAN drivers ctrlmode the provided new content
> has to be checked whether the bits are allowed to be changed.
> The bits that are to be changed are given as a bitfield in cm->mask.
> Therefore checking against cm->flags is wrong as the content can hold
> any kind of values.
> 
> The iproute2 tool sets the bits in cm->mask and cm->flags depending on
> the detected command line options. To be robust against bogus user space
> applications additionally sanitize the provided flags with the provided
> mask.
> 
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> CC: Wolfgang Grandegger <wg@grandegger.com>

Does not apply to net/master. However I've applied it by hand. v2 will
follow.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]