From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 1EDE5E008E5; Wed, 7 Jan 2015 07:12:46 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from smtp.webfaction.com (mail6.webfaction.com [74.55.86.74]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id AA921E005A9 for ; Wed, 7 Jan 2015 07:12:42 -0800 (PST) Received: from [192.168.1.10] (c-73-194-208-34.hsd1.nj.comcast.net [73.194.208.34]) by smtp.webfaction.com (Postfix) with ESMTP id 6E85020A109D; Wed, 7 Jan 2015 15:12:41 +0000 (UTC) Message-ID: <54AD4CE8.5080401@mindchasers.com> Date: Wed, 07 Jan 2015 10:12:40 -0500 From: Bob Cochran User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: ting.liu@freescale.com, meta-freescale@yoctoproject.org References: <1420605208-3545-1-git-send-email-ting.liu@freescale.com> <1420605208-3545-13-git-send-email-ting.liu@freescale.com> In-Reply-To: <1420605208-3545-13-git-send-email-ting.liu@freescale.com> Subject: Re: [meta-fsl-ppc][PATCH 12/12] multilib: use ?= to allow overridden in local.conf X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jan 2015 15:12:46 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit This patch does not apply properly. See below plus a comment on commit log... On 01/06/2015 11:33 PM, ting.liu@freescale.com wrote: > From: Ting Liu > > the multilib setting have already been moved to the machine > configure file. I'm not sure what you mean. Aren't the machine config files the ones in "meta-fsl-ppc/conf/machine" MULTILIBS is not set in any of machine conf files (e.g., t1040rdb-64b.conf). The only conf files I see MULTILIBS being used are in the e5500 and e6500 include files. according to the including order in bitbake.conf > the machine configure file is after local.conf file.so the value > in local.conf will be overridden. change to use ?=. > > This is useful when using external toolchain which does not need > to enable multilib. > > Signed-off-by: Zongchun Yu > --- > conf/machine/include/e5500-64b.inc | 4 ++-- > conf/machine/include/e6500-64b.inc | 4 ++-- > conf/machine/include/e6500.inc | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/conf/machine/include/e5500-64b.inc b/conf/machine/include/e5500-64b.inc > index a8b69dd..d6d3cfd 100644 > --- a/conf/machine/include/e5500-64b.inc > +++ b/conf/machine/include/e5500-64b.inc > @@ -7,7 +7,7 @@ require conf/machine/include/qoriq-base.inc > MACHINEOVERRIDES .= ":e5500-64b" > > require conf/multilib.conf > -MULTILIBS = "multilib:lib32" > -DEFAULTTUNE_virtclass-multilib-lib32 = "ppce5500" > +MULTILIBS ?= "multilib:lib32" > +DEFAULTTUNE_virtclass-multilib-lib32 ?= "ppce5500" > USER_CLASSES_remove = "image-prelink" I'm seeing errors when applying this patch. I don't see a "USER_CLASSES_remove = "image-prelink" line in these conf files. > > diff --git a/conf/machine/include/e6500-64b.inc b/conf/machine/include/e6500-64b.inc > index 6b7297b..f98f402 100644 > --- a/conf/machine/include/e6500-64b.inc > +++ b/conf/machine/include/e6500-64b.inc > @@ -7,7 +7,7 @@ require conf/machine/include/qoriq-base.inc > MACHINEOVERRIDES .= ":e6500-64b" > > require conf/multilib.conf > -MULTILIBS = "multilib:lib32" > -DEFAULTTUNE_virtclass-multilib-lib32 = "ppce6500" > +MULTILIBS ?= "multilib:lib32" > +DEFAULTTUNE_virtclass-multilib-lib32 ?= "ppce6500" > USER_CLASSES_remove = "image-prelink" Line doesn't exist > > diff --git a/conf/machine/include/e6500.inc b/conf/machine/include/e6500.inc > index e6848bd..4121fbe 100644 > --- a/conf/machine/include/e6500.inc > +++ b/conf/machine/include/e6500.inc > @@ -8,6 +8,6 @@ MACHINEOVERRIDES .= ":e6500" > BUILD_64BIT_KERNEL = "1" > > require conf/multilib.conf > -MULTILIBS = "multilib:lib64" > -DEFAULTTUNE_virtclass-multilib-lib64 = "ppc64e6500" > +MULTILIBS ?= "multilib:lib64" > +DEFAULTTUNE_virtclass-multilib-lib64 ?= "ppc64e6500" > >