Re: [PATCH 1/2] time: settimeofday: Validate the values of tv from user

[Sasha Levin <sasha.levin@oracle.com>]

On 01/07/2015 02:02 PM, John Stultz wrote:
> On Wed, Jan 7, 2015 at 10:28 AM, Greg KH <greg@kroah.com> wrote:
>> On Wed, Jan 07, 2015 at 10:12:19AM -0800, John Stultz wrote:
>>> From: Sasha Levin <sasha.levin@oracle.com>
>>>
>>> An unvalidated user input is multiplied by a constant, which can result in
>>> an undefined behaviour for large values. While this is validated later,
>>> we should avoid triggering undefined behaviour.
>>>
>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: stable <stable@vger.kernel.org>
>>> Cc: Andy Lutomirski <luto@amacapital.net>
>>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>>> [jstultz: include trivial milisecond->microsecond correction noticed
>>> by Andy]
>>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>>> ---
>>>  include/linux/time.h | 13 +++++++++++++
>>>  kernel/time/time.c   |  4 ++++
>>>  2 files changed, 17 insertions(+)
>>
>> <formletter>
>>
>> This is not the correct way to submit patches for inclusion in the
>> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
>> for how to do this properly.
>>
>> </formletter>
> 
> Hrm. I'm not quite sure which rule I'm running afoul here.
> 
> Does this seem too much like a theoretical issue and not like enough
> of a "oh, that's not good" issue?

I suspect it's something more like "Cc: stable <stable@vger.kernel.org>" vs
"Cc: stable@vger.kernel.org", but not really sure.


Thanks,
Sasha