From: Dave Hansen <dave.hansen@linux.intel.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andi Kleen <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3.19 3/3] x86, mpx: Change the MPX enable/disable API to arch_prctl
Date: Wed, 07 Jan 2015 15:18:09 -0800 [thread overview]
Message-ID: <54ADBEB1.7000902@linux.intel.com> (raw)
In-Reply-To: <CALCETrUeMS7zwjXfSMN-6A8-gpLc68n7U5Y6SPdzgw6hSbYGNg@mail.gmail.com>
On 01/05/2015 03:04 PM, Andy Lutomirski wrote:
> Anyway, if it's actually a problem to change it, I have no real
> problem keeping it, but I think we *really* need to validate the rest
> of the arguments at the very least.
If we "validate" the arguments like you suggested, then a call like this:
prctl(PR_MPX_DISABLE_MANAGEMENT);
ends up returning -EINVAL:
> prctl(0x2b /* PR_??? */, 0x7fffffd3, 0x7f360955e9e0, 0x2c, 0x7f3609314840) = -1 EINVAL (Invalid argument)
A quick grep through ltp and some other source I have laying around does
*not* show folks adding 0's to these calls for "empty" arguments. Is
this really something we want to do?
prctl(PR_MPX_DISABLE_MANAGEMENT, 0, 0, 0, 0);
next prev parent reply other threads:[~2015-01-07 23:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 0:52 [PATCH 3.19 0/3] Possible MPX improvements for 3.19 Andy Lutomirski
2014-12-30 0:52 ` [PATCH 3.19 1/3] x86, mpx: Check user mode bitness correctly when decoding instructions Andy Lutomirski
2015-01-07 17:22 ` Dave Hansen
2015-01-12 22:48 ` Andy Lutomirski
2014-12-30 0:52 ` [PATCH 3.19 2/3] x86, mpx: Short-circuit the instruction decoder for unexpected opcodes Andy Lutomirski
2014-12-30 0:58 ` Andy Lutomirski
2014-12-30 0:52 ` [PATCH 3.19 3/3] x86, mpx: Change the MPX enable/disable API to arch_prctl Andy Lutomirski
2015-01-02 7:53 ` Dave Hansen
2015-01-05 20:42 ` Andi Kleen
2015-01-05 21:18 ` Dave Hansen
2015-01-05 23:04 ` Andy Lutomirski
2015-01-05 23:10 ` Dave Hansen
2015-01-05 23:22 ` Andy Lutomirski
2015-01-06 4:04 ` Andi Kleen
2015-01-06 5:59 ` Andy Lutomirski
2015-01-06 17:48 ` Dave Hansen
2015-01-06 18:06 ` Andy Lutomirski
2015-01-06 18:30 ` Dave Hansen
2015-01-06 18:41 ` Andy Lutomirski
2015-01-06 18:54 ` Dave Hansen
2015-01-06 19:16 ` Andi Kleen
2015-01-06 19:51 ` Andy Lutomirski
2015-01-06 21:22 ` Andi Kleen
2015-01-06 21:34 ` Andy Lutomirski
2015-01-06 21:39 ` Andi Kleen
2015-01-12 10:34 ` Enkovich, Ilya
2015-01-07 23:18 ` Dave Hansen [this message]
2015-01-07 23:24 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ADBEB1.7000902@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.