From: Daniel Borkmann <dborkman@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: fw@strlen.de, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 -next v2] ip: route: add congestion control metric
Date: Thu, 08 Jan 2015 00:37:48 +0100 [thread overview]
Message-ID: <54ADC34C.9030505@redhat.com> (raw)
In-Reply-To: <20150107150657.1defa6bd@urahara>
On 01/08/2015 12:06 AM, Stephen Hemminger wrote:
> On Wed, 7 Jan 2015 12:28:18 +0100
> Daniel Borkmann <dborkman@redhat.com> wrote:
>
>> + if (i != RTAX_CC_ALGO)
>> + val = *(unsigned *)RTA_DATA(mxrta[i]);
>
> Please use rta_getattr_u32 here.
>
> Yes, I know you copied old code, but the old code predated the helper
> functions.
No problem, that looks better indeed. Will add it.
Btw, while we're on the topic, we ignore errors for all rta_addattr*()
functions f.e. in iproute_modify(). I think at least we should undo the
mxlock in case of an error (or bail out entirely as a different option).
Thanks,
Daniel
prev parent reply other threads:[~2015-01-07 23:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 11:28 [PATCH iproute2 -next v2] ip: route: add congestion control metric Daniel Borkmann
2015-01-07 23:06 ` Stephen Hemminger
2015-01-07 23:37 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ADC34C.9030505@redhat.com \
--to=dborkman@redhat.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.