From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1Y90lF-000728-4h
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 19:15:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1Y90lA-0004ne-SK
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 19:15:37 -0500
Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:21029)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1Y90lA-0004nZ-H3
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 19:15:32 -0500
From: Don Slutz <dslutz@verizon.com>
Message-ID: <54ADCC22.4060902@terremark.com>
Date: Wed, 07 Jan 2015 19:15:30 -0500
MIME-Version: 1.0
References: <20150107172040.29974.56600.stgit@gimli.home>
In-Reply-To: <20150107172040.29974.56600.stgit@gimli.home>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] vfio-pci: Fix BAR size overflow
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>, qemu-devel@nongnu.org

On 01/07/15 12:23, Alex Williamson wrote:
> We use an unsigned int when working with the PCI BAR size, which can
> obviously overflow if the BAR is 4GB or larger.  This needs to change
> to a fixed length uint64_t.  A similar issue is possible, though even
> more unlikely, when mapping the region above an MSI-X table.  The
> start of the MSI-X vector table must be below 4GB, but the end, and
> therefore the start of the next mapping region, could still land at
> 4GB.
> 
> Suggested-by: Nishank Trivedi <nishank.trivedi@netapp.com>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> 

Looks good.

Reviewed-by: Don Slutz <dslutz@verizon.com>

   -Don Slutz

> v2: s/unsigned long/uint64_t/, duh
> 
>  hw/vfio/pci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index b4e73d1..b6703c7 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -2301,7 +2301,7 @@ static void vfio_unmap_bar(VFIOPCIDevice *vdev, int nr)
>  static void vfio_map_bar(VFIOPCIDevice *vdev, int nr)
>  {
>      VFIOBAR *bar = &vdev->bars[nr];
> -    unsigned size = bar->region.size;
> +    uint64_t size = bar->region.size;
>      char name[64];
>      uint32_t pci_bar;
>      uint8_t type;
> @@ -2351,7 +2351,7 @@ static void vfio_map_bar(VFIOPCIDevice *vdev, int nr)
>      }
>  
>      if (vdev->msix && vdev->msix->table_bar == nr) {
> -        unsigned start;
> +        uint64_t start;
>  
>          start = HOST_PAGE_ALIGN(vdev->msix->table_offset +
>                                  (vdev->msix->entries * PCI_MSIX_ENTRY_SIZE));
> 
>