From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vince Hsu Subject: Re: [PATCH v1] drm/nouveau/clk: avoid potential null-dereference Date: Thu, 8 Jan 2015 12:32:06 +0800 Message-ID: <54AE0846.4000503@nvidia.com> References: <1420669790-6525-1-git-send-email-andy.shevchenko@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) by gabe.freedesktop.org (Postfix) with ESMTP id A98676E692 for ; Wed, 7 Jan 2015 20:31:59 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ilia Mirkin , Andy Shevchenko Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org Ck9uIDAxLzA4LzIwMTUgMTA6NDUgQU0sIElsaWEgTWlya2luIHdyb3RlOgo+IE9uIFdlZCwgSmFu IDcsIDIwMTUgYXQgNToyOSBQTSwgQW5keSBTaGV2Y2hlbmtvCj4gPGFuZHkuc2hldmNoZW5rb0Bn bWFpbC5jb20+IHdyb3RlOgo+PiBXZSBoYXZlIHRvIGNoZWNrIHBvaW50ZXIgYmVmb3JlIHVzYWdl Lgo+Pgo+PiBSZXBvcnRlZC1ieTogQW5kcmV5IEthcnBvdiA8a2FycG92QHZpdmE2NC5jb20+Cj4+ IFNpZ25lZC1vZmYtYnk6IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNv bT4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvY29yZS9zdWJkZXYvY2xvY2sv YmFzZS5jIHwgNCArKystCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvY29y ZS9zdWJkZXYvY2xvY2svYmFzZS5jIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvY29yZS9zdWJk ZXYvY2xvY2svYmFzZS5jCj4+IGluZGV4IGU1MWI3MmQuLjJlODQ0MzYgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2NvcmUvc3ViZGV2L2Nsb2NrL2Jhc2UuYwo+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9jb3JlL3N1YmRldi9jbG9jay9iYXNlLmMKPj4gQEAg LTMyMiw3ICszMjIsNiBAQCBub3V2ZWF1X3BzdGF0ZV9uZXcoc3RydWN0IG5vdXZlYXVfY2xvY2sg KmNsaywgaW50IGlkeCkKPj4gICAgICAgICAgICAgICAgICByZXR1cm4gMDsKPj4KPj4gICAgICAg ICAgcHN0YXRlID0ga3phbGxvYyhzaXplb2YoKnBzdGF0ZSksIEdGUF9LRVJORUwpOwo+PiAtICAg ICAgIGNzdGF0ZSA9ICZwc3RhdGUtPmJhc2U7Cj4gV2hhdCdzIHdyb25nIHdpdGggdGhpcyBsaW5l PyBJZiBwc3RhdGUgPT0gTlVMTCwgJnBzdGF0ZS0+YmFzZSA9PSBOVUxMCj4gYXMgd2VsbCBhbmQg d2UgcmV0dXJuLgpJZiBwc3RhdGUgPT0gTlVMTCAoa3phbGxvYyByZXR1cm5lZCBOVUxMKSwgcHN0 YXRlLT5iYXNlIHRyaWdnZXJzIGEgbnVsbCAKcG9pbnRlcgpkZWZlcmVuY2UgZXJyb3I/CgpUaGFu a3MsClZpbmNlCgo+Cj4+ICAgICAgICAgIGlmICghcHN0YXRlKQo+PiAgICAgICAgICAgICAgICAg IHJldHVybiAtRU5PTUVNOwo+Pgo+PiBAQCAtMzMwLDYgKzMyOSw5IEBAIG5vdXZlYXVfcHN0YXRl X25ldyhzdHJ1Y3Qgbm91dmVhdV9jbG9jayAqY2xrLCBpbnQgaWR4KQo+Pgo+PiAgICAgICAgICBw c3RhdGUtPnBzdGF0ZSA9IHBlcmZFLnBzdGF0ZTsKPj4gICAgICAgICAgcHN0YXRlLT5mYW5zcGVl ZCA9IHBlcmZFLmZhbnNwZWVkOwo+PiArCj4+ICsgICAgICAgY3N0YXRlID0gJnBzdGF0ZS0+YmFz ZTsKPj4gKwo+PiAgICAgICAgICBjc3RhdGUtPnZvbHRhZ2UgPSBwZXJmRS52b2x0YWdlOwo+PiAg ICAgICAgICBjc3RhdGUtPmRvbWFpbltudl9jbGtfc3JjX2NvcmVdID0gcGVyZkUuY29yZTsKPj4g ICAgICAgICAgY3N0YXRlLT5kb21haW5bbnZfY2xrX3NyY19zaGFkZXJdID0gcGVyZkUuc2hhZGVy Owo+PiAtLQo+PiAxLjguMy4xMDEuZzcyN2E0NmIKPj4KPj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+PiBk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t ClRoaXMgZW1haWwgbWVzc2FnZSBpcyBmb3IgdGhlIHNvbGUgdXNlIG9mIHRoZSBpbnRlbmRlZCBy ZWNpcGllbnQocykgYW5kIG1heSBjb250YWluCmNvbmZpZGVudGlhbCBpbmZvcm1hdGlvbi4gIEFu eSB1bmF1dGhvcml6ZWQgcmV2aWV3LCB1c2UsIGRpc2Nsb3N1cmUgb3IgZGlzdHJpYnV0aW9uCmlz IHByb2hpYml0ZWQuICBJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5kZWQgcmVjaXBpZW50LCBwbGVh c2UgY29udGFjdCB0aGUgc2VuZGVyIGJ5CnJlcGx5IGVtYWlsIGFuZCBkZXN0cm95IGFsbCBjb3Bp ZXMgb2YgdGhlIG9yaWdpbmFsIG1lc3NhZ2UuCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==