From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vince Hsu Subject: Re: [PATCH v1] drm/nouveau/clk: avoid potential null-dereference Date: Thu, 8 Jan 2015 13:40:02 +0800 Message-ID: <54AE1832.9070907@nvidia.com> References: <1420669790-6525-1-git-send-email-andy.shevchenko@gmail.com> <54AE0846.4000503@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 252C46E60B for ; Wed, 7 Jan 2015 21:40:49 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ilia Mirkin Cc: Andy Shevchenko , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gMDEvMDgvMjAxNSAxMjo1NyBQTSwgSWxpYSBNaXJraW4gd3JvdGU6Cj4gT24gV2VkLCBKYW4g NywgMjAxNSBhdCAxMTozMiBQTSwgVmluY2UgSHN1IDx2aW5jZWhAbnZpZGlhLmNvbT4gd3JvdGU6 Cj4+IE9uIDAxLzA4LzIwMTUgMTA6NDUgQU0sIElsaWEgTWlya2luIHdyb3RlOgo+Pj4gT24gV2Vk LCBKYW4gNywgMjAxNSBhdCA1OjI5IFBNLCBBbmR5IFNoZXZjaGVua28KPj4+IDxhbmR5LnNoZXZj aGVua29AZ21haWwuY29tPiB3cm90ZToKPj4+PiBXZSBoYXZlIHRvIGNoZWNrIHBvaW50ZXIgYmVm b3JlIHVzYWdlLgo+Pj4+Cj4+Pj4gUmVwb3J0ZWQtYnk6IEFuZHJleSBLYXJwb3YgPGthcnBvdkB2 aXZhNjQuY29tPgo+Pj4+IFNpZ25lZC1vZmYtYnk6IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2 Y2hlbmtvQGdtYWlsLmNvbT4KPj4+PiAtLS0KPj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vbm91dmVh dS9jb3JlL3N1YmRldi9jbG9jay9iYXNlLmMgfCA0ICsrKy0KPj4+PiAgICAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvY29yZS9zdWJkZXYvY2xvY2svYmFzZS5jCj4+Pj4gYi9k cml2ZXJzL2dwdS9kcm0vbm91dmVhdS9jb3JlL3N1YmRldi9jbG9jay9iYXNlLmMKPj4+PiBpbmRl eCBlNTFiNzJkLi4yZTg0NDM2IDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2 ZWF1L2NvcmUvc3ViZGV2L2Nsb2NrL2Jhc2UuYwo+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9u b3V2ZWF1L2NvcmUvc3ViZGV2L2Nsb2NrL2Jhc2UuYwo+Pj4+IEBAIC0zMjIsNyArMzIyLDYgQEAg bm91dmVhdV9wc3RhdGVfbmV3KHN0cnVjdCBub3V2ZWF1X2Nsb2NrICpjbGssIGludAo+Pj4+IGlk eCkKPj4+PiAgICAgICAgICAgICAgICAgICByZXR1cm4gMDsKPj4+Pgo+Pj4+ICAgICAgICAgICBw c3RhdGUgPSBremFsbG9jKHNpemVvZigqcHN0YXRlKSwgR0ZQX0tFUk5FTCk7Cj4+Pj4gLSAgICAg ICBjc3RhdGUgPSAmcHN0YXRlLT5iYXNlOwo+Pj4gV2hhdCdzIHdyb25nIHdpdGggdGhpcyBsaW5l PyBJZiBwc3RhdGUgPT0gTlVMTCwgJnBzdGF0ZS0+YmFzZSA9PSBOVUxMCj4+PiBhcyB3ZWxsIGFu ZCB3ZSByZXR1cm4uCj4+IElmIHBzdGF0ZSA9PSBOVUxMIChremFsbG9jIHJldHVybmVkIE5VTEwp LCBwc3RhdGUtPmJhc2UgdHJpZ2dlcnMgYSBudWxsCj4+IHBvaW50ZXIKPj4gZGVmZXJlbmNlIGVy cm9yPwo+IFdoZXJlIGRvIHlvdSBzZWUgInBzdGF0ZS0+YmFzZSI/IEkgb25seSBzZWUgIiZwc3Rh dGUtPmJhc2UiIHdoaWNoCj4gbWVyZWx5IGNvbXB1dGVzIGFuIG9mZnNldCBpbnRvIGEgc3RydWN0 dXJlLi4uIE5vIHJlYXNvbiB0byBkZXJlZmVyZW5jZQo+IHBzdGF0ZS4KU29ycnkgdGhhdCBJIGRv bid0IHF1aXRlIHVuZGVyc3RhbmQuIFdlIGRvIG5lZWQgZGVmZXJlbmNlIHBzdGF0ZSB0byBnZXQK dGhlIG1lbWJlciBiYXNlIHdoaWNoIGhhcyB0eXBlIG5vdXZlYXVfY3N0YXRlLCBhbmQgdGhlbiBh c3NpZ24KdGhlIGFkZHJlc3Mgb2YgYmFzZSB0byBjc3RhdGUgZm9yIGxhdGVyIHVzZS4KCnN0cnVj dCBub3V2ZWF1X3BzdGF0ZSB7CiAgICAgc3RydWN0IGxpc3RfaGVhZCBoZWFkOwogICAgIHN0cnVj dCBsaXN0X2hlYWQgbGlzdDsgLyogYy1zdGF0ZXMgKi8KICAgICBzdHJ1Y3Qgbm91dmVhdV9jc3Rh dGUgYmFzZTsKICAgICB1OCBwc3RhdGU7CiAgICAgdTggZmFuc3BlZWQ7Cn07CgpUaGFua3MsClZp bmNlCgoKCgoKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KVGhpcyBlbWFpbCBtZXNzYWdlIGlz IGZvciB0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKSBhbmQgbWF5IGNv bnRhaW4KY29uZmlkZW50aWFsIGluZm9ybWF0aW9uLiAgQW55IHVuYXV0aG9yaXplZCByZXZpZXcs IHVzZSwgZGlzY2xvc3VyZSBvciBkaXN0cmlidXRpb24KaXMgcHJvaGliaXRlZC4gIElmIHlvdSBh cmUgbm90IHRoZSBpbnRlbmRlZCByZWNpcGllbnQsIHBsZWFzZSBjb250YWN0IHRoZSBzZW5kZXIg YnkKcmVwbHkgZW1haWwgYW5kIGRlc3Ryb3kgYWxsIGNvcGllcyBvZiB0aGUgb3JpZ2luYWwgbWVz c2FnZS4KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK