From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vince Hsu Subject: Re: [PATCH v1] drm/nouveau/clk: avoid potential null-dereference Date: Thu, 8 Jan 2015 14:02:31 +0800 Message-ID: <54AE1D77.5010709@nvidia.com> References: <1420669790-6525-1-git-send-email-andy.shevchenko@gmail.com> <54AE0846.4000503@nvidia.com> <54AE1832.9070907@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) by gabe.freedesktop.org (Postfix) with ESMTP id 8957A6E69C for ; Wed, 7 Jan 2015 22:02:34 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ilia Mirkin Cc: Andy Shevchenko , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org Ck9uIDAxLzA4LzIwMTUgMDE6NTIgUE0sIElsaWEgTWlya2luIHdyb3RlOgo+IE9uIFRodSwgSmFu IDgsIDIwMTUgYXQgMTI6NDAgQU0sIFZpbmNlIEhzdSA8dmluY2VoQG52aWRpYS5jb20+IHdyb3Rl Ogo+PiBPbiAwMS8wOC8yMDE1IDEyOjU3IFBNLCBJbGlhIE1pcmtpbiB3cm90ZToKPj4+IE9uIFdl ZCwgSmFuIDcsIDIwMTUgYXQgMTE6MzIgUE0sIFZpbmNlIEhzdSA8dmluY2VoQG52aWRpYS5jb20+ IHdyb3RlOgo+Pj4+IE9uIDAxLzA4LzIwMTUgMTA6NDUgQU0sIElsaWEgTWlya2luIHdyb3RlOgo+ Pj4+PiBPbiBXZWQsIEphbiA3LCAyMDE1IGF0IDU6MjkgUE0sIEFuZHkgU2hldmNoZW5rbwo+Pj4+ PiA8YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4gd3JvdGU6Cj4+Pj4+PiBXZSBoYXZlIHRvIGNo ZWNrIHBvaW50ZXIgYmVmb3JlIHVzYWdlLgo+Pj4+Pj4KPj4+Pj4+IFJlcG9ydGVkLWJ5OiBBbmRy ZXkgS2FycG92IDxrYXJwb3ZAdml2YTY0LmNvbT4KPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEFuZHkg U2hldmNoZW5rbyA8YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4KPj4+Pj4+IC0tLQo+Pj4+Pj4g ICAgIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2NvcmUvc3ViZGV2L2Nsb2NrL2Jhc2UuYyB8IDQg KysrLQo+Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKPj4+Pj4+Cj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUv Y29yZS9zdWJkZXYvY2xvY2svYmFzZS5jCj4+Pj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1 L2NvcmUvc3ViZGV2L2Nsb2NrL2Jhc2UuYwo+Pj4+Pj4gaW5kZXggZTUxYjcyZC4uMmU4NDQzNiAx MDA2NDQKPj4+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2NvcmUvc3ViZGV2L2Ns b2NrL2Jhc2UuYwo+Pj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvY29yZS9zdWJk ZXYvY2xvY2svYmFzZS5jCj4+Pj4+PiBAQCAtMzIyLDcgKzMyMiw2IEBAIG5vdXZlYXVfcHN0YXRl X25ldyhzdHJ1Y3Qgbm91dmVhdV9jbG9jayAqY2xrLCBpbnQKPj4+Pj4+IGlkeCkKPj4+Pj4+ICAg ICAgICAgICAgICAgICAgICByZXR1cm4gMDsKPj4+Pj4+Cj4+Pj4+PiAgICAgICAgICAgIHBzdGF0 ZSA9IGt6YWxsb2Moc2l6ZW9mKCpwc3RhdGUpLCBHRlBfS0VSTkVMKTsKPj4+Pj4+IC0gICAgICAg Y3N0YXRlID0gJnBzdGF0ZS0+YmFzZTsKPj4+Pj4gV2hhdCdzIHdyb25nIHdpdGggdGhpcyBsaW5l PyBJZiBwc3RhdGUgPT0gTlVMTCwgJnBzdGF0ZS0+YmFzZSA9PSBOVUxMCj4+Pj4+IGFzIHdlbGwg YW5kIHdlIHJldHVybi4KPj4+PiBJZiBwc3RhdGUgPT0gTlVMTCAoa3phbGxvYyByZXR1cm5lZCBO VUxMKSwgcHN0YXRlLT5iYXNlIHRyaWdnZXJzIGEgbnVsbAo+Pj4+IHBvaW50ZXIKPj4+PiBkZWZl cmVuY2UgZXJyb3I/Cj4+PiBXaGVyZSBkbyB5b3Ugc2VlICJwc3RhdGUtPmJhc2UiPyBJIG9ubHkg c2VlICImcHN0YXRlLT5iYXNlIiB3aGljaAo+Pj4gbWVyZWx5IGNvbXB1dGVzIGFuIG9mZnNldCBp bnRvIGEgc3RydWN0dXJlLi4uIE5vIHJlYXNvbiB0byBkZXJlZmVyZW5jZQo+Pj4gcHN0YXRlLgo+ PiBTb3JyeSB0aGF0IEkgZG9uJ3QgcXVpdGUgdW5kZXJzdGFuZC4gV2UgZG8gbmVlZCBkZWZlcmVu Y2UgcHN0YXRlIHRvIGdldAo+PiB0aGUgbWVtYmVyIGJhc2Ugd2hpY2ggaGFzIHR5cGUgbm91dmVh dV9jc3RhdGUsIGFuZCB0aGVuIGFzc2lnbgo+PiB0aGUgYWRkcmVzcyBvZiBiYXNlIHRvIGNzdGF0 ZSBmb3IgbGF0ZXIgdXNlLgo+Pgo+PiBzdHJ1Y3Qgbm91dmVhdV9wc3RhdGUgewo+PiAgICAgIHN0 cnVjdCBsaXN0X2hlYWQgaGVhZDsKPj4gICAgICBzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7IC8qIGMt c3RhdGVzICovCj4+ICAgICAgc3RydWN0IG5vdXZlYXVfY3N0YXRlIGJhc2U7Cj4+ICAgICAgdTgg cHN0YXRlOwo+PiAgICAgIHU4IGZhbnNwZWVkOwo+PiB9Owo+ICZwc3RhdGUtPmJhc2UgaXMgdGhl IHNhbWUgdGhpbmcgYXMKPgo+ICh2b2lkICopcHN0YXRlICsgb2Zmc2V0b2Yoc3RydWN0IG5vdXZl YXVfcHN0YXRlLCBiYXNlKQo+Cj4gQXQgbm8gcG9pbnQgaXMgcHN0YXRlIGRlcmVmZXJlbmNlZC4g SW4gZmFjdCwgdGFrZSBhIGxvb2sgYXQKPgo+IGh0dHA6Ly9lbi53aWtpcGVkaWEub3JnL3dpa2kv T2Zmc2V0b2YKPgo+IHdoaWNoIHNheXMgdGhhdCB0aGUgdHJhZGl0aW9uYWwgaW1wbGVtZW50YXRp b24gb2Ygb2Zmc2V0b2YgaXMKPgo+ICNkZWZpbmUgb2Zmc2V0b2Yoc3QsIG0pICgoc2l6ZV90KSgm KChzdCAqKTApLT5tKSkKPgpPaCBJIGdvdCB5b3VyIHBvaW50LiBZb3UncmUgYWJzb2x1dGVseSBy aWdodC4gVGhhbmtzIGZvciB0aGUgcGF0aWVuY2UuIDopCgpWaW5jZQoKCi0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tClRoaXMgZW1haWwgbWVzc2FnZSBpcyBmb3IgdGhlIHNvbGUgdXNlIG9mIHRo ZSBpbnRlbmRlZCByZWNpcGllbnQocykgYW5kIG1heSBjb250YWluCmNvbmZpZGVudGlhbCBpbmZv cm1hdGlvbi4gIEFueSB1bmF1dGhvcml6ZWQgcmV2aWV3LCB1c2UsIGRpc2Nsb3N1cmUgb3IgZGlz dHJpYnV0aW9uCmlzIHByb2hpYml0ZWQuICBJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5kZWQgcmVj aXBpZW50LCBwbGVhc2UgY29udGFjdCB0aGUgc2VuZGVyIGJ5CnJlcGx5IGVtYWlsIGFuZCBkZXN0 cm95IGFsbCBjb3BpZXMgb2YgdGhlIG9yaWdpbmFsIG1lc3NhZ2UuCi0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==