Re: [PATCH v4] can/peak_usb: add support for PEAK new CANFD USB adapters

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]

On 01/07/2015 06:37 PM, Oliver Hartkopp wrote:
> On 07.01.2015 18:03, Marc Kleine-Budde wrote:
>> On 01/06/2015 11:00 AM, Stephane Grosjean wrote:
>>> Add support for the following new PEAK-System technik CANFD USB
>>> adapters:
>>>
>>> PCAN-USB FD             single CANFD channel USB adapter
>>> PCAN-USB Pro FD         dual CANFD channels USB adapter
>>
>> Can you please work out the correct ISO/non-ISO for CAN-fd with Oliver.
>> If you need CAN_CTRLMODE_FD_NON_ISO make your patch based on
>>
>>      https://gitorious.org/linux-can/linux-can.git testing
>>
> 
> Good idea.
> 
> @Stephane: Do you already have the latest UCAN IP core from Philipp
> which supports the ISO/non-ISO switching? (I don't have it)
> 
> The question is if it makes sense to provide a driver for the current
> UCAN IP core and later provide a separate patch when the new
> (switchable) UCAN IP core is available.
> 
> But in this case we need to check for the UCAN revision whether it is
> fixed to non-ISO or if it is switchable.
> 
> Maybe it makes sense to support ONLY the latest (== switchable) UCAN
> revision for the mainline driver. The update to the latest UCAN revision
> is mandatory anyway.

I think supporting both variants is the way to go. As there are some
devices with the old firmware in the wild, you have to check the
firmware revision anyways.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]