From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bn0107.outbound.protection.outlook.com [157.56.110.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 982491A0F8E for ; Thu, 8 Jan 2015 20:32:29 +1100 (AEDT) Message-ID: <54AE4E81.4040507@Freescale.com> Date: Thu, 8 Jan 2015 03:31:45 -0600 From: Emil Medve MIME-Version: 1.0 To: Scott Wood Subject: Re: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan References: <1419321466-5575-1-git-send-email-shh.xie@gmail.com> <1420590520.4961.38.camel@freescale.com> <1420653934.4961.58.camel@freescale.com> <54AD8C8A.8070100@Freescale.com> <1420679558.4961.64.camel@freescale.com> In-Reply-To: <1420679558.4961.64.camel@freescale.com> Content-Type: text/plain; charset="utf-8" Cc: "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , Xie Shaohui-B21989 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello Scott, On 01/07/2015 07:12 PM, Scott Wood wrote: > On Wed, 2015-01-07 at 13:44 -0600, Emil Medve wrote: >> Hello Scott, >> >> >> On 01/07/2015 12:05 PM, Scott Wood wrote: >>> On Tue, 2015-01-06 at 23:29 -0600, Xie Shaohui-B21989 wrote: >>>>>>> +- interrupts >>>>>>> + Usage: optional >>>>>>> + Value type: >>>>>>> + Definition: Event interrupt of external MDIO controller. >>>>>>> + 1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively. >>>>> >>>>> I'm confused by "respectively" here. Does fsl,fman-memac-mdio have two >>>>> interrupts (one for 1 Gb/s and one for 10 Gb/s)? >>>> [S.H] We use two MDIO controllers for external PHY management. One for 1 Gb/s, >>>> One for 10 Gb/s, and two MDIO interrupts connected to MPIC. >>> >>> If there can be two interrupts you need to make that clear and specify >>> the order. >>> >>> Is it possible for one MDIO controller to have an interrupt connected >>> but not the other, on the same system? How would you represent that in >>> the device tree? If there are two MDIO controllers why are they in the >>> same node? >> >> Historically (FMan v2 and even before/legacy) we've had each MAC include >> an MDIO controller, but only one MDIO controller per MAC type/speed (1 >> Gb/s vs 10 Gb/s) is pinned out and all the same speed PHY(s) are >> connected to the respective MDIO controllers. As such the first 1 Gb/s >> MAC/MDIO controller is used to manage all the 1 Gb/s PHY(s) and the >> first 10 Gb/s MAC/MDIO controller is used to manage all the 10 Gb/s >> PHY(s). Each MDIO controller has the ability to generate interrupts but >> only pinned out MDIO controllers are hooked up to the MPIC (as such the >> talk about two interrupts) >> >> (Each MAC has also integrated a SERDES/TBI/"internal" PHY that is >> connected to the "local" MDIO controller) >> >> As you can imagine this creates a number of problems in a partitioning >> scenario (and not just, imagine RCWs where the first MAC is not >> used/enabled). In order to help a bit (but not quite enough), in FMan >> v3, two additional MDIO controllers (one for 1 the Gb/s PHY(s) and one >> for 1 the 10 Gb/s PHY(s)) have been integrated that are not associated >> with any MAC and these are the pinned out MDIO controllers on such >> SoC(s) (chassis v2) > > I'm happy to hear that. Is that what is meant by "external" here? "External" doesn't mean external to the MAC nodes. "External" doesn't even properly apply to the MDIO controller(s) at all but to the PHY(s). > I thought it meant external to the SoC. Is this the term used by > hardware documentation? The documentation (mostly chip errata documents) refers to external/internal MDIO accesses and as on FMan v3 external PHY accesses are always made via these extra MDIO controllers (pinned oud) and the internal SERDES PHY accesses are always made via the in-MAC MDIO controllers some level of confusion is easy to be achieved. All the MDIO controllers are identical whether they are in-MAC or standalone > I'd have called it "independent" or similar. To make things even more confusing, some documents call these extra MDIO controllers "dedicated" Cheers, >>>> Does "optional" mean it's used if and >>>>> only if external MDIO is used, or is it optional even with external MDIO? I see >>>>> it's not present in the example -- do we not have a real example that has the >>>>> interrupt? >>>> [S.H] "optional" means it's available on hardware, but MDIO driver does not use interrupt. >>>> So we don't have a real example. >>> >>> The device tree describes the hardware, not the >>> driver >> >> Anyway, only two MDIO nodes (out of 4 to 14) would have an interrupt >> property describing exactly one interrupt. What language should we use >> to convey this situation > > So the answer is that there will not be more than one MDIO controller > per MDIO node, or more than one interrupt per MDIO node? In that case > just get rid of the confusing "respectively" sentence -- and always > describe the interrupt if it exists in hardware. > > -Scott > > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Medve Subject: Re: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan Date: Thu, 8 Jan 2015 03:31:45 -0600 Message-ID: <54AE4E81.4040507@Freescale.com> References: <1419321466-5575-1-git-send-email-shh.xie@gmail.com> <1420590520.4961.38.camel@freescale.com> <1420653934.4961.58.camel@freescale.com> <54AD8C8A.8070100@Freescale.com> <1420679558.4961.64.camel@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1420679558.4961.64.camel@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Scott Wood Cc: "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , Xie Shaohui-B21989 List-Id: devicetree@vger.kernel.org SGVsbG8gU2NvdHQsCgoKT24gMDEvMDcvMjAxNSAwNzoxMiBQTSwgU2NvdHQgV29vZCB3cm90ZToK PiBPbiBXZWQsIDIwMTUtMDEtMDcgYXQgMTM6NDQgLTA2MDAsIEVtaWwgTWVkdmUgd3JvdGU6Cj4+ IEhlbGxvIFNjb3R0LAo+Pgo+Pgo+PiBPbiAwMS8wNy8yMDE1IDEyOjA1IFBNLCBTY290dCBXb29k IHdyb3RlOgo+Pj4gT24gVHVlLCAyMDE1LTAxLTA2IGF0IDIzOjI5IC0wNjAwLCBYaWUgU2hhb2h1 aS1CMjE5ODkgd3JvdGU6Cj4+Pj4+Pj4gKy0gaW50ZXJydXB0cwo+Pj4+Pj4+ICsJCVVzYWdlOiBv cHRpb25hbAo+Pj4+Pj4+ICsJCVZhbHVlIHR5cGU6IDxwcm9wLWVuY29kZWQtYXJyYXk+Cj4+Pj4+ Pj4gKwkJRGVmaW5pdGlvbjogRXZlbnQgaW50ZXJydXB0IG9mIGV4dGVybmFsIE1ESU8gY29udHJv bGxlci4KPj4+Pj4+PiArCQkxIEdiL3MgTURJTyBhbmQgMTAgR2IvcyBNRElPIGhhcyBvbmUgaW50 ZXJydXB0IHJlc3BlY3RpdmVseS4KPj4+Pj4KPj4+Pj4gSSdtIGNvbmZ1c2VkIGJ5ICJyZXNwZWN0 aXZlbHkiIGhlcmUuICBEb2VzIGZzbCxmbWFuLW1lbWFjLW1kaW8gaGF2ZSB0d28KPj4+Pj4gaW50 ZXJydXB0cyAob25lIGZvciAxIEdiL3MgYW5kIG9uZSBmb3IgMTAgR2Ivcyk/Cj4+Pj4gW1MuSF0g V2UgdXNlIHR3byBNRElPIGNvbnRyb2xsZXJzIGZvciBleHRlcm5hbCBQSFkgbWFuYWdlbWVudC4g T25lIGZvciAxIEdiL3MsCj4+Pj4gT25lIGZvciAxMCBHYi9zLCBhbmQgdHdvIE1ESU8gaW50ZXJy dXB0cyBjb25uZWN0ZWQgdG8gTVBJQy4KPj4+Cj4+PiBJZiB0aGVyZSBjYW4gYmUgdHdvIGludGVy cnVwdHMgeW91IG5lZWQgdG8gbWFrZSB0aGF0IGNsZWFyIGFuZCBzcGVjaWZ5Cj4+PiB0aGUgb3Jk ZXIuCj4+Pgo+Pj4gSXMgaXQgcG9zc2libGUgZm9yIG9uZSBNRElPIGNvbnRyb2xsZXIgdG8gaGF2 ZSBhbiBpbnRlcnJ1cHQgY29ubmVjdGVkCj4+PiBidXQgbm90IHRoZSBvdGhlciwgb24gdGhlIHNh bWUgc3lzdGVtPyAgSG93IHdvdWxkIHlvdSByZXByZXNlbnQgdGhhdCBpbgo+Pj4gdGhlIGRldmlj ZSB0cmVlPyAgSWYgdGhlcmUgYXJlIHR3byBNRElPIGNvbnRyb2xsZXJzIHdoeSBhcmUgdGhleSBp biB0aGUKPj4+IHNhbWUgbm9kZT8KPj4KPj4gSGlzdG9yaWNhbGx5IChGTWFuIHYyIGFuZCBldmVu IGJlZm9yZS9sZWdhY3kpIHdlJ3ZlIGhhZCBlYWNoIE1BQyBpbmNsdWRlCj4+IGFuIE1ESU8gY29u dHJvbGxlciwgYnV0IG9ubHkgb25lIE1ESU8gY29udHJvbGxlciBwZXIgTUFDIHR5cGUvc3BlZWQg KDEKPj4gR2IvcyB2cyAxMCBHYi9zKSBpcyBwaW5uZWQgb3V0IGFuZCBhbGwgdGhlIHNhbWUgc3Bl ZWQgUEhZKHMpIGFyZQo+PiBjb25uZWN0ZWQgdG8gdGhlIHJlc3BlY3RpdmUgTURJTyBjb250cm9s bGVycy4gQXMgc3VjaCB0aGUgZmlyc3QgMSBHYi9zCj4+IE1BQy9NRElPIGNvbnRyb2xsZXIgaXMg dXNlZCB0byBtYW5hZ2UgYWxsIHRoZSAxIEdiL3MgUEhZKHMpIGFuZCB0aGUKPj4gZmlyc3QgMTAg R2IvcyBNQUMvTURJTyBjb250cm9sbGVyIGlzIHVzZWQgdG8gbWFuYWdlIGFsbCB0aGUgMTAgR2Iv cwo+PiBQSFkocykuIEVhY2ggTURJTyBjb250cm9sbGVyIGhhcyB0aGUgYWJpbGl0eSB0byBnZW5l cmF0ZSBpbnRlcnJ1cHRzIGJ1dAo+PiBvbmx5IHBpbm5lZCBvdXQgTURJTyBjb250cm9sbGVycyBh cmUgaG9va2VkIHVwIHRvIHRoZSBNUElDIChhcyBzdWNoIHRoZQo+PiB0YWxrIGFib3V0IHR3byBp bnRlcnJ1cHRzKQo+Pgo+PiAoRWFjaCBNQUMgaGFzIGFsc28gaW50ZWdyYXRlZCBhIFNFUkRFUy9U QkkvImludGVybmFsIiBQSFkgdGhhdCBpcwo+PiBjb25uZWN0ZWQgdG8gdGhlICJsb2NhbCIgTURJ TyBjb250cm9sbGVyKQo+Pgo+PiBBcyB5b3UgY2FuIGltYWdpbmUgdGhpcyBjcmVhdGVzIGEgbnVt YmVyIG9mIHByb2JsZW1zIGluIGEgcGFydGl0aW9uaW5nCj4+IHNjZW5hcmlvIChhbmQgbm90IGp1 c3QsIGltYWdpbmUgUkNXcyB3aGVyZSB0aGUgZmlyc3QgTUFDIGlzIG5vdAo+PiB1c2VkL2VuYWJs ZWQpLiBJbiBvcmRlciB0byBoZWxwIGEgYml0IChidXQgbm90IHF1aXRlIGVub3VnaCksIGluIEZN YW4KPj4gdjMsIHR3byBhZGRpdGlvbmFsIE1ESU8gY29udHJvbGxlcnMgKG9uZSBmb3IgMSB0aGUg R2IvcyBQSFkocykgYW5kIG9uZQo+PiBmb3IgMSB0aGUgMTAgR2IvcyBQSFkocykpIGhhdmUgYmVl biBpbnRlZ3JhdGVkIHRoYXQgYXJlIG5vdCBhc3NvY2lhdGVkCj4+IHdpdGggYW55IE1BQyBhbmQg dGhlc2UgYXJlIHRoZSBwaW5uZWQgb3V0IE1ESU8gY29udHJvbGxlcnMgb24gc3VjaAo+PiBTb0Mo cykgKGNoYXNzaXMgdjIpCj4gCj4gSSdtIGhhcHB5IHRvIGhlYXIgdGhhdC4gIElzIHRoYXQgd2hh dCBpcyBtZWFudCBieSAiZXh0ZXJuYWwiIGhlcmU/CgoiRXh0ZXJuYWwiIGRvZXNuJ3QgbWVhbiBl eHRlcm5hbCB0byB0aGUgTUFDIG5vZGVzLiAiRXh0ZXJuYWwiIGRvZXNuJ3QKZXZlbiBwcm9wZXJs eSBhcHBseSB0byB0aGUgTURJTyBjb250cm9sbGVyKHMpIGF0IGFsbCBidXQgdG8gdGhlIFBIWShz KS4KCj4gSSB0aG91Z2h0IGl0IG1lYW50IGV4dGVybmFsIHRvIHRoZSBTb0MuICBJcyB0aGlzIHRo ZSB0ZXJtIHVzZWQgYnkKPiBoYXJkd2FyZSBkb2N1bWVudGF0aW9uPwoKVGhlIGRvY3VtZW50YXRp b24gKG1vc3RseSBjaGlwIGVycmF0YSBkb2N1bWVudHMpIHJlZmVycyB0bwpleHRlcm5hbC9pbnRl cm5hbCBNRElPIGFjY2Vzc2VzIGFuZCBhcyBvbiBGTWFuIHYzIGV4dGVybmFsIFBIWSBhY2Nlc3Nl cwphcmUgYWx3YXlzIG1hZGUgdmlhIHRoZXNlIGV4dHJhIE1ESU8gY29udHJvbGxlcnMgKHBpbm5l ZCBvdWQpIGFuZCB0aGUKaW50ZXJuYWwgU0VSREVTIFBIWSBhY2Nlc3NlcyBhcmUgYWx3YXlzIG1h ZGUgdmlhIHRoZSBpbi1NQUMgTURJTwpjb250cm9sbGVycyBzb21lIGxldmVsIG9mIGNvbmZ1c2lv biBpcyBlYXN5IHRvIGJlIGFjaGlldmVkLiBBbGwgdGhlIE1ESU8KY29udHJvbGxlcnMgYXJlIGlk ZW50aWNhbCB3aGV0aGVyIHRoZXkgYXJlIGluLU1BQyBvciBzdGFuZGFsb25lCgo+IEknZCBoYXZl IGNhbGxlZCBpdCAiaW5kZXBlbmRlbnQiIG9yIHNpbWlsYXIuCgpUbyBtYWtlIHRoaW5ncyBldmVu IG1vcmUgY29uZnVzaW5nLCBzb21lIGRvY3VtZW50cyBjYWxsIHRoZXNlIGV4dHJhIE1ESU8KY29u dHJvbGxlcnMgImRlZGljYXRlZCIKCgpDaGVlcnMsCgoKPj4+PiAgIERvZXMgIm9wdGlvbmFsIiBt ZWFuIGl0J3MgdXNlZCBpZiBhbmQKPj4+Pj4gb25seSBpZiBleHRlcm5hbCBNRElPIGlzIHVzZWQs IG9yIGlzIGl0IG9wdGlvbmFsIGV2ZW4gd2l0aCBleHRlcm5hbCBNRElPPyAgSSBzZWUKPj4+Pj4g aXQncyBub3QgcHJlc2VudCBpbiB0aGUgZXhhbXBsZSAtLSBkbyB3ZSBub3QgaGF2ZSBhIHJlYWwg ZXhhbXBsZSB0aGF0IGhhcyB0aGUKPj4+Pj4gaW50ZXJydXB0Pwo+Pj4+IFtTLkhdICJvcHRpb25h bCIgbWVhbnMgaXQncyBhdmFpbGFibGUgb24gaGFyZHdhcmUsIGJ1dCBNRElPIGRyaXZlciBkb2Vz IG5vdCB1c2UgaW50ZXJydXB0LiAKPj4+PiBTbyB3ZSBkb24ndCBoYXZlIGEgcmVhbCBleGFtcGxl Lgo+Pj4KPj4+IDxyZWNvcmQgdHlwZT0iYnJva2VuIj5UaGUgZGV2aWNlIHRyZWUgZGVzY3JpYmVz IHRoZSBoYXJkd2FyZSwgbm90IHRoZQo+Pj4gZHJpdmVyPC9yZWNvcmQ+Cj4+Cj4+IEFueXdheSwg b25seSB0d28gTURJTyBub2RlcyAob3V0IG9mIDQgdG8gMTQpIHdvdWxkIGhhdmUgYW4gaW50ZXJy dXB0Cj4+IHByb3BlcnR5IGRlc2NyaWJpbmcgZXhhY3RseSBvbmUgaW50ZXJydXB0LiBXaGF0IGxh bmd1YWdlIHNob3VsZCB3ZSB1c2UKPj4gdG8gY29udmV5IHRoaXMgc2l0dWF0aW9uCj4gCj4gU28g dGhlIGFuc3dlciBpcyB0aGF0IHRoZXJlIHdpbGwgbm90IGJlIG1vcmUgdGhhbiBvbmUgTURJTyBj b250cm9sbGVyCj4gcGVyIE1ESU8gbm9kZSwgb3IgbW9yZSB0aGFuIG9uZSBpbnRlcnJ1cHQgcGVy IE1ESU8gbm9kZT8gIEluIHRoYXQgY2FzZQo+IGp1c3QgZ2V0IHJpZCBvZiB0aGUgY29uZnVzaW5n ICJyZXNwZWN0aXZlbHkiIHNlbnRlbmNlIC0tIGFuZCBhbHdheXMKPiBkZXNjcmliZSB0aGUgaW50 ZXJydXB0IGlmIGl0IGV4aXN0cyBpbiBoYXJkd2FyZS4KPiAKPiAtU2NvdHQKPiAKPiAKPiAuCj4g CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eHBw Yy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8v bGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY=