From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 0/8] KVM: x86: Emulator fixes Date: Thu, 08 Jan 2015 11:42:34 +0100 Message-ID: <54AE5F1A.2030204@redhat.com> References: <1419468743-23732-1-git-send-email-namit@cs.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Nadav Amit Return-path: Received: from mail-wg0-f43.google.com ([74.125.82.43]:33762 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753784AbbAHKmk (ORCPT ); Thu, 8 Jan 2015 05:42:40 -0500 Received: by mail-wg0-f43.google.com with SMTP id k14so1830711wgh.2 for ; Thu, 08 Jan 2015 02:42:39 -0800 (PST) In-Reply-To: <1419468743-23732-1-git-send-email-namit@cs.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 25/12/2014 01:52, Nadav Amit wrote: > Few more emulator fixes. Each is logically independent from the others. > > The first one is the most interesting one. It appears that the current > behavior may cause the VM to enter the page-fault handler twice on certain > faulting write accesses. If you do not like my solution, please propose a > better one. > > The fourth (JMP/CALL using call- or task-gate) is not a fix, but returns an > error instead of emulating the wrong (#GP) exception. > > Thanks for reviewing the patches. > > Nadav Amit (8): > KVM: x86: #PF error-code on R/W operations is wrong > KVM: x86: pop sreg accesses only 2 bytes > KVM: x86: fnstcw and fnstsw may cause spurious exception > KVM: x86: JMP/CALL using call- or task-gate causes exception > KVM: x86: em_call_far should return failure result > KVM: x86: POP [ESP] is not emulated correctly > KVM: x86: Do not set access bit on accessed segments > KVM: x86: Access to LDT/GDT that wraparound is incorrect > > arch/x86/include/asm/kvm_host.h | 12 ++++ > arch/x86/kvm/emulate.c | 138 ++++++++++++++++++++++++++-------------- > arch/x86/kvm/mmu.h | 12 ---- > 3 files changed, 103 insertions(+), 59 deletions(-) > I'm applying patches 2-8. I want to play a bit more with patch 1. Paolo