From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9Bad-0001Sa-It for qemu-devel@nongnu.org; Thu, 08 Jan 2015 06:49:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9Baa-0003Y5-E7 for qemu-devel@nongnu.org; Thu, 08 Jan 2015 06:49:23 -0500 Received: from lnx3.fantu.it ([94.23.245.208]:34262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9Baa-0003V6-3z for qemu-devel@nongnu.org; Thu, 08 Jan 2015 06:49:20 -0500 Message-ID: <54AE6EA9.9000508@tiscali.it> Date: Thu, 08 Jan 2015 12:48:57 +0100 From: Fabio Fantoni MIME-Version: 1.0 References: <1508539.cfTQauU1Ry@javinlg> In-Reply-To: <1508539.cfTQauU1Ry@javinlg> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms040801010309010108050509" Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE Reply-To: fantonifabio@tiscali.it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Javier Celaya , qemu-devel@nongnu.org Cc: spice-devel , flex.dev@nologin.es, Anthony Liguori This is a cryptographically signed message in MIME format. --------------ms040801010309010108050509 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Il 08/01/2015 11:50, Javier Celaya ha scritto: > Hello > > Recently, SPICE included the lz4 compression algorithm. This patch adds= > a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 d= id not=20 > exist before the commit that added this compression algorithm, so it sh= ould be=20 > guarded with conditional compilation. How do you think this should be d= one?=20 > Wait for the next stable version of spice-server and check for=20 > SPICE_SERVER_VERSION? Or add a specific flag? > > Thank you > --- > ui/spice-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index 6467fa4..fb6534e 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -359,6 +359,7 @@ static const char *compression_names[] =3D { > [ SPICE_IMAGE_COMPRESS_QUIC ] =3D "quic", > [ SPICE_IMAGE_COMPRESS_GLZ ] =3D "glz", > [ SPICE_IMAGE_COMPRESS_LZ ] =3D "lz", > + [ SPICE_IMAGE_COMPRESS_LZ4 ] =3D "lz4", > }; > #define parse_compression(_name) = \ > parse_name(_name, "image compression", = \ > -- > 1.9.3 I did a small search now and seems that also other small change to qemu-options.hx file should be done, search this line: @item image-compression=3D[auto_glz|auto_lz|quic|glz|lz|off] > > _______________________________________________ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel > > > --------------ms040801010309010108050509 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: Firma crittografica S/MIME MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIMsTCC BjQwggQcoAMCAQICASAwDQYJKoZIhvcNAQEFBQAwfTELMAkGA1UEBhMCSUwxFjAUBgNVBAoT DVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNp Z25pbmcxKTAnBgNVBAMTIFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MB4XDTA3 MTAyNDIxMDI1NVoXDTE3MTAyNDIxMDI1NVowgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1T dGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWdu aW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAyIFByaW1hcnkgSW50ZXJtZWRpYXRlIENs aWVudCBDQTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMsohUWcASz7GfKrpTOM KqANy9BV7V0igWdGxA8IU77L3aTxErQ+fcxtDYZ36Z6GH0YFn7fq5RADteP0AYzrCA+EQTfi 8q1+kA3m0nwtwXG94M5sIqsvs7lRP1aycBke/s5g9hJHryZ2acScnzczjBCAo7X1v5G3yw8M DP2m2RCye0KfgZ4nODerZJVzhAlOD9YejvAXZqHksw56HzElVIoYSZ3q4+RJuPXXfIoyby+Y 2m1E+YzX5iCZXBx05gk6MKAW1vaw4/v2OOLy6FZH3XHHtOkzUreG//CsFnB9+uaYSlR65cdG zTsmoIK8WH1ygoXhRBm98SD7Hf/r3FELNvUCAwEAAaOCAa0wggGpMA8GA1UdEwEB/wQFMAMB Af8wDgYDVR0PAQH/BAQDAgEGMB0GA1UdDgQWBBSuVYNv7DHKufcd+q9rMfPIHeOsuzAfBgNV HSMEGDAWgBROC+8apEBbpRdphzDKNGhD0EGu8jBmBggrBgEFBQcBAQRaMFgwJwYIKwYBBQUH MAGGG2h0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNvbS9jYTAtBggrBgEFBQcwAoYhaHR0cDovL3d3 dy5zdGFydHNzbC5jb20vc2ZzY2EuY3J0MFsGA1UdHwRUMFIwJ6AloCOGIWh0dHA6Ly93d3cu c3RhcnRzc2wuY29tL3Nmc2NhLmNybDAnoCWgI4YhaHR0cDovL2NybC5zdGFydHNzbC5jb20v c2ZzY2EuY3JsMIGABgNVHSAEeTB3MHUGCysGAQQBgbU3AQIBMGYwLgYIKwYBBQUHAgEWImh0 dHA6Ly93d3cuc3RhcnRzc2wuY29tL3BvbGljeS5wZGYwNAYIKwYBBQUHAgEWKGh0dHA6Ly93 d3cuc3RhcnRzc2wuY29tL2ludGVybWVkaWF0ZS5wZGYwDQYJKoZIhvcNAQEFBQADggIBADqp Jw3I07QWke9plNBpxUxcffc7nUrIQpJHDci91DFG7fVhHRkMZ1J+BKg5UNUxIFJ2Z9B90Mic c/NXcs7kPBRdn6XGO/vPc87Y6R+cWS9Nc9+fp3Enmsm94OxOwI9wn8qnr/6o3mD4noP9Jphw UPTXwHovjavRnhUQHLfo/i2NG0XXgTHXS2Xm0kVUozXqpYpAdumMiB/vezj1QHQJDmUdPYMc p+reg9901zkyT3fDW/ivJVv6pWtkh6Pw2ytZT7mvg7YhX3V50Nv860cV11mocUVcqBLv0gcT +HBDYtbuvexNftwNQKD5193A7zN4vG7CTYkXxytSjKuXrpEatEiFPxWgb84nVj25SU5q/r1X hwby6mLhkbaXslkVtwEWT3Van49rKjlK4XrUKYYWtnfzq6aSak5u0Vpxd1rY79tWhD3EdCvO hNz/QplNa+VkIsrcp7+8ZhP1l1b2U6MaxIVteuVMD3X0vziIwr7jxYae9FZjbxlpUemqXjcC 0QaFfN7qI0JsQMALL7iGRBg7K0CoOBzECdD3fuZil5kU/LP9cr1BK31U0Uy651bFnAMMMkqh AChIbn0ei72VnbpSsrrSdF0BAGYQ8vyHae5aCg+H75dVCV33K6FuxZrf09yTz+Vx/PkdRUYk XmZz/OTfyJXsUOUXrym6KvI2rYpccSk5MIIGdTCCBV2gAwIBAgICSD8wDQYJKoZIhvcNAQEF BQAwgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJT ZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFydENvbSBD bGFzcyAyIFByaW1hcnkgSW50ZXJtZWRpYXRlIENsaWVudCBDQTAeFw0xNDAzMjgyMDMyMTBa Fw0xNjAzMjkxMDA5NTNaMIGMMRkwFwYDVQQNExBXUnUxOWdzOFBEYmcwNTBJMQswCQYDVQQG EwJJVDEQMA4GA1UECBMHQmVyZ2FtbzEQMA4GA1UEBxMHUm92ZXR0YTEWMBQGA1UEAxMNRmFi aW8gRmFudG9uaTEmMCQGCSqGSIb3DQEJARYXZmFudG9uaWZhYmlvQHRpc2NhbGkuaXQwggEi MA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDaGyFHyGrg8i9IZFHhWZHIx01/wslgoQD4 8XFmb4NafAEtUJpfdadMZXFjS9ea/k5P+Xw83mtZdEXNOnf8IXg8FmsiwAt6Ujdz+CZD1w+0 0+lVN3yt0sCbUUOXrWjSv59rOZnFA801A8epnh8tjATQugZ7r96rLE4Vk8PT+ksp8U2dIDZH NHhfbmcvdx1Bk5Y/PB3IbPaCDGW9M0YoILOvjClmilMtigcB8YuaqWkVqULvcagfIoFWKinL ylTzsleIcZsduvOIAp8nzVvT/b8Ogi0TYR3e67j9a9Zpt5F7oRHrCxBHlCfaTHEhh6svXawl aYFWfxdrfuvuoJRPJtAdAgMBAAGjggLdMIIC2TAJBgNVHRMEAjAAMAsGA1UdDwQEAwIEsDAd BgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwHQYDVR0OBBYEFGfU6G9lcLCruABqxYo6 qtmlt2iPMB8GA1UdIwQYMBaAFK5Vg2/sMcq59x36r2sx88gd46y7MCIGA1UdEQQbMBmBF2Zh bnRvbmlmYWJpb0B0aXNjYWxpLml0MIIBTAYDVR0gBIIBQzCCAT8wggE7BgsrBgEEAYG1NwEC AzCCASowLgYIKwYBBQUHAgEWImh0dHA6Ly93d3cuc3RhcnRzc2wuY29tL3BvbGljeS5wZGYw gfcGCCsGAQUFBwICMIHqMCcWIFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MAMC AQEagb5UaGlzIGNlcnRpZmljYXRlIHdhcyBpc3N1ZWQgYWNjb3JkaW5nIHRvIHRoZSBDbGFz cyAyIFZhbGlkYXRpb24gcmVxdWlyZW1lbnRzIG9mIHRoZSBTdGFydENvbSBDQSBwb2xpY3ks IHJlbGlhbmNlIG9ubHkgZm9yIHRoZSBpbnRlbmRlZCBwdXJwb3NlIGluIGNvbXBsaWFuY2Ug b2YgdGhlIHJlbHlpbmcgcGFydHkgb2JsaWdhdGlvbnMuMDYGA1UdHwQvMC0wK6ApoCeGJWh0 dHA6Ly9jcmwuc3RhcnRzc2wuY29tL2NydHUyLWNybC5jcmwwgY4GCCsGAQUFBwEBBIGBMH8w OQYIKwYBBQUHMAGGLWh0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNvbS9zdWIvY2xhc3MyL2NsaWVu dC9jYTBCBggrBgEFBQcwAoY2aHR0cDovL2FpYS5zdGFydHNzbC5jb20vY2VydHMvc3ViLmNs YXNzMi5jbGllbnQuY2EuY3J0MCMGA1UdEgQcMBqGGGh0dHA6Ly93d3cuc3RhcnRzc2wuY29t LzANBgkqhkiG9w0BAQUFAAOCAQEABT91kQvIXq/qcTjfY3Q08cQ96PYn1ucqLydhjWr/UJTS kGubQTptxURT3Sga8SSWWxVOjdvOSyVmNG2TcYoq6oToILvto8MPJGuNa2uVltl7tG6qyfg/ 1JwqNInfCt+VAbiIiA86tN/V3kuc7vYPJ1/ah6cS9oKV58zltZ6Ww0DZ567Ax0mvcExndOLa 2KHb6J6ZxaxEZDWppBe7pwZOBHZhlB/SGwEq4ktsaecm98cJ3c0IqGyxEC3zMF3qUIwfUrlW a99IPu7fcQrhBGPmczWFvwvUkSuk0+A4ShNdK4Ss9QDDoQc07iAFkq7dz5LJ/F7hNkHsBeZX xX6OHJOqUjGCA9owggPWAgEBMIGTMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UEChMNU3RhcnRD b20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2lnbmluZzE4 MDYGA1UEAxMvU3RhcnRDb20gQ2xhc3MgMiBQcmltYXJ5IEludGVybWVkaWF0ZSBDbGllbnQg Q0ECAkg/MAkGBSsOAwIaBQCgggIbMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZI hvcNAQkFMQ8XDTE1MDEwODExNDg1N1owIwYJKoZIhvcNAQkEMRYEFJznOc0a1LeG4/6nVcEu pSa6tvyTMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAKBggq hkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZI hvcNAwICASgwgaQGCSsGAQQBgjcQBDGBljCBkzCBjDELMAkGA1UEBhMCSUwxFjAUBgNVBAoT DVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNp Z25pbmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDIgUHJpbWFyeSBJbnRlcm1lZGlhdGUg Q2xpZW50IENBAgJIPzCBpgYLKoZIhvcNAQkQAgsxgZaggZMwgYwxCzAJBgNVBAYTAklMMRYw FAYDVQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZp Y2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAyIFByaW1hcnkgSW50ZXJt ZWRpYXRlIENsaWVudCBDQQICSD8wDQYJKoZIhvcNAQEBBQAEggEAJd/3h7YFes59HBLisTXw ENKbDmMnAuXbf1woqdcaRlpSzTh0PSWRN2LcROdmJzyzOpcmWrHZ8dH9qF25D8Ux+cM5EUvk p73H3c65DOaPKja72bsau2PHwcG0nsowj3l/6aTtc1oz93fh5f83K3vZttD0UCekTeVIzATI CV35HJfeDh9QSEDPR2St/jsWViOtpbWZvo6dMGPgZETp7jGFLmva03GOTxSG4PI8gyNzOSfS lAzczMSuMY6gwhmw65CHZUBxo8ATWQ8VQXG5zIDhZMLHehrNRb3zfzxXu6dz3IvuJREWtKGH zFu8l1s4sewAEutIyLZhN2YQsuzUc2hcdQAAAAAAAA== --------------ms040801010309010108050509--