From: Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: <linux-wireless@vger.kernel.org>, <wil6210@qca.qualcomm.com>
Subject: Re: [PATCH 17/22] wil6210: add advanced interrupt moderation
Date: Thu, 8 Jan 2015 14:24:44 +0200 [thread overview]
Message-ID: <54AE770C.4080006@qca.qualcomm.com> (raw)
In-Reply-To: <87mw5vt3fb.fsf@kamboji.qca.qualcomm.com>
On 01/07/2015 10:12 AM, Kalle Valo wrote:
> The number of module parameters feels a little excessive, especially
> when you add one more in the following patch. Is it really necessary for
> the user to configure all these? Why can't the driver pick good
> defaults?
Unfortunately, all these are really tunable parameters that impact
performance.
I also realized it is too much. If we will find appropriate defaults for
some parameters, not requiting tuning, I'll upload patch removing it.
Thanks, Vladimir
next prev parent reply other threads:[~2015-01-08 12:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 7:47 [PATCH 00/22] wil6210 patches Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 01/22] wil6210: ADDBA/DELBA flows Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 02/22] wil6210: simple ADDBA on originator (Tx) side Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 03/22] wil6210: allow to configure ADDBA request Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 04/22] wil6210: improve debugfs for reorder buffer Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 05/22] wil6210: fix disconnect 1 STA in AP Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 06/22] wil6210: improve debugfs for VRING Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 07/22] wil6210: control AMSDU on Tx side of Block Ack Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 08/22] wil6210: delba for responder Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 09/22] wil6210: fix max. MPDU size Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 10/22] wil6210: consider SNAP header in MTU calculations Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 11/22] wil6210: Increase number of associated stations Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 12/22] wil6210: use bitmap API for "status" Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 13/22] wil6210: fix Tx VRING for STA mode Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 14/22] wil6210: rework debugfs for BACK Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 15/22] wil6210: detect HW capabilities Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 16/22] wil6210: use HW capabilities mask in reset Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 17/22] wil6210: add advanced interrupt moderation Vladimir Kondratiev
2015-01-07 8:12 ` Kalle Valo
2015-01-08 12:24 ` Vladimir Kondratiev [this message]
2015-01-15 12:15 ` Kalle Valo
2014-12-23 7:47 ` [PATCH 18/22] wil6210: RX high threshold interrupt configuration Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 19/22] wil6210: fix reordering for MCAST Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 20/22] wil6210: Tx/Rx descriptors documentation Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 21/22] wil6210: workaround for BACK establishment race Vladimir Kondratiev
2014-12-23 7:47 ` [PATCH 22/22] wil6210: relax spinlocks in rx reorder Vladimir Kondratiev
2015-01-15 12:37 ` [PATCH 00/22] wil6210 patches Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AE770C.4080006@qca.qualcomm.com \
--to=qca_vkondrat@qca.qualcomm.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.