From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/4] dt-uart: use ':' as separator between path and options Date: Thu, 08 Jan 2015 12:26:31 +0000 Message-ID: <54AE7777.8090204@linaro.org> References: <1420718009.19787.44.camel@citrix.com> <1420718036-29651-3-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1420718036-29651-3-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 08/01/15 11:53, Ian Campbell wrote: > diff --git a/xen/drivers/char/dt-uart.c b/xen/drivers/char/dt-uart.c > index 04dbb97..b9a0956 100644 > --- a/xen/drivers/char/dt-uart.c > +++ b/xen/drivers/char/dt-uart.c > @@ -31,7 +31,7 @@ > * doesn't start with '/', we assuming that it's an alias. > * @options: UART speficic options (see in each UART driver) > */ You forgot to modify the comment: "Configure UART port with a string: path,options" With this change: Reviewed-by: Julien Grall Regards, -- Julien Grall