From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCHv2] arch:x86:kvm:Add function for setting pending timer
 on virtual cpu in x86.c
Date: Thu, 08 Jan 2015 13:32:09 +0100
Message-ID: <54AE78C9.9010308@redhat.com>
References: <1420167918-2190-1-git-send-email-xerofoify@gmail.com> <54AE709B.2040605@redhat.com> <54AE74F2.7050700@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
To: Andrej Manduch <amanduch@gmail.com>,
	Nicholas Krause <xerofoify@gmail.com>, gleb@kernel.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <54AE74F2.7050700@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 08/01/2015 13:15, Andrej Manduch wrote:
>>> >> -	/* FIXME: this code should not know anything about vcpus */
> I don't want to sounds like I'm nitpicking. But I need to ask. Why is
> this comment removed?

Because the real point of the comment was that the code should not know
anything about VCPU requests.  But it's okay to call a function to tell
the VCPU "we want you to call us back at kvm_inject_apic_timer_irqs".

Paolo

>>> >> -	kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu);
>>> >> +	kvm_set_pending_timer(vcpu);