From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 4/4] dt-uart: support /chosen/stdout-path
	property.
Date: Thu, 08 Jan 2015 13:30:37 +0000
Message-ID: <54AE867D.5030903@linaro.org>
References: <1420718009.19787.44.camel@citrix.com>	
	<1420718036-29651-4-git-send-email-ian.campbell@citrix.com>	
	<54AE82EA.1090703@linaro.org>
	<1420723344.19787.76.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1420723344.19787.76.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 08/01/15 13:22, Ian Campbell wrote:
> On Thu, 2015-01-08 at 13:15 +0000, Julien Grall wrote:
>> Hi Ian,
>>
>> On 08/01/15 11:53, Ian Campbell wrote:
>>> +            ret = dt_property_read_string(chosen, "stdout-path", &stdout);
>>> +            if ( ret >= 0 )
>>> +            {
>>> +                printk("Taking dtuart configuration from /chosen/stdout-path\n");
>>> +                if ( strlcpy(opt_dtuart, stdout, sizeof(opt_dtuart))
>>> +                     >= sizeof(opt_dtuart) )
>>> +                    printk("WARNING: /chosen/stdout-path too long, truncated\n");
>>
>> I would add XENLOG_WARNING here and ...
>>
>>> +            }
>>> +            else if ( ret != -EINVAL /* Not present */ )
>>> +                printk("Failed to read /chosen/stdout-path (%d)\n", ret);
>>
>> XENLOG_ERROR here.
> 
> In practice these only go via the earlyprintk mechanism, since the
> console can't be setup yet. I'm not sure it's worthwhile tagging such
> messages.

earlyprintk is transparent for the console code. Tagging may help if we
decide to implement other kind of console later (VGA, PCI UART...).

Anyway, I doesn't change much things here as the message is tagged as
WARNING by default. So it will be always printing.

Regards,

-- 
Julien Grall