From: David Vrabel <david.vrabel@citrix.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, <x86@kernel.org>
Cc: Andrew Jones <drjones@redhat.com>, <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
David Vrabel <david.vrabel@citrix.com>,
"H. Peter Anvin" <hpa@zytor.com>,
<xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Laszlo Ersek <lersek@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Xen-devel] [PATCH v2] x86/xen: avoid freeing static 'name' when kasprintf() fails
Date: Thu, 8 Jan 2015 14:36:52 +0000 [thread overview]
Message-ID: <54AE9604.4040901@citrix.com> (raw)
In-Reply-To: <1420471671-32051-1-git-send-email-vkuznets@redhat.com>
On 05/01/15 15:27, Vitaly Kuznetsov wrote:
> In case kasprintf() fails in xen_setup_timer() we assign name to the static
> string "<timer kasprintf failed>". We, however, don't check that fact before
> issuing kfree() in xen_teardown_timer(), kernel is supposed to crash with
> 'kernel BUG at mm/slub.c:3341!'
>
> Solve the issue by making name a fixed length string inside struct
> xen_clock_event_device. 16 bytes should be enough.
Applied to stable/for-linus-3.19, thanks.
David
next prev parent reply other threads:[~2015-01-08 14:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 13:06 [PATCH] x86/xen: avoid freeing static 'name' when kasprintf() fails Vitaly Kuznetsov
2015-01-05 13:19 ` David Vrabel
2015-01-05 13:19 ` [Xen-devel] " David Vrabel
2015-01-05 13:58 ` Laszlo Ersek
2015-01-05 13:58 ` Laszlo Ersek
2015-01-05 15:27 ` [PATCH v2] " Vitaly Kuznetsov
2015-01-05 15:36 ` Laszlo Ersek
2015-01-05 15:36 ` Laszlo Ersek
2015-01-08 14:36 ` David Vrabel
2015-01-08 14:36 ` David Vrabel [this message]
2015-01-05 15:27 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AE9604.4040901@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=drjones@redhat.com \
--cc=hpa@zytor.com \
--cc=lersek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.