From: "Sébastien Barré" <sebastien.barre@uclouvain.be>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
Gregory Detal <gregory.detal@uclouvain.be>,
Nandita Dukkipati <nanditad@google.com>,
Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH net-next v2] tcp: avoid reducing cwnd when ACK+DSACK is received
Date: Thu, 8 Jan 2015 16:24:10 +0100 [thread overview]
Message-ID: <54AEA11A.1000603@uclouvain.be> (raw)
In-Reply-To: <1420729656.5947.50.camel@edumazet-glaptop2.roam.corp.google.com>
Hi Eric,
Le 08/01/2015 16:07, Eric Dumazet a écrit :
>
>> In the current code,
>> such ACK+DSACK will be missed and only at next, higher ack will the TLP
>> episode be considered done. Since the DSACK is not present anymore,
>> this will cost a cwnd reduction.
>>
>> This patch ensures that this scenario does not cause a cwnd reduction, since
>> receiving an ACK+DSACK indicates that both the initial segment and the probe
>> have been received by the peer.
> Do you have at hand a packetdrill test to demonstrate that the patch
> works ?
Not currently, but that would be very good indeed.
I will prepare one and send it.
regards,
Sébastien.
>
> Thanks !
>
>
next prev parent reply other threads:[~2015-01-08 15:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 12:20 [PATCH net-next v2] tcp: avoid reducing cwnd when ACK+DSACK is received Sébastien Barré
2015-01-08 15:07 ` Eric Dumazet
2015-01-08 15:24 ` Sébastien Barré [this message]
2015-01-08 15:43 ` Neal Cardwell
2015-01-08 16:00 ` Sébastien Barré
2015-01-08 15:59 ` Eric Dumazet
2015-01-08 15:19 ` Eric Dumazet
2015-01-08 15:39 ` Sébastien Barré
2015-01-08 15:49 ` Neal Cardwell
2015-01-08 15:52 ` Neal Cardwell
2015-01-08 16:25 ` Eric Dumazet
2015-01-08 17:17 ` Eric Dumazet
2015-01-08 17:27 ` Eric Dumazet
2015-01-09 19:43 ` Yuchung Cheng
2015-01-09 20:36 ` Neal Cardwell
2015-01-10 11:51 ` Sébastien Barré
2015-01-10 17:37 ` Eric Dumazet
2015-01-12 11:52 ` David Laight
2015-01-12 15:02 ` Neal Cardwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AEA11A.1000603@uclouvain.be \
--to=sebastien.barre@uclouvain.be \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gregory.detal@uclouvain.be \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.