From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/3] x86: also allow REP STOS emulation
	acceleration
Date: Thu, 8 Jan 2015 19:29:04 +0000
Message-ID: <54AEDA80.4080405@citrix.com>
References: <54AEB49C0200007800052BDE@mail.emea.novell.com>
	<54AEB5690200007800052BF1@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1Y9Iub-00023U-3h
	for xen-devel@lists.xenproject.org; Thu, 08 Jan 2015 19:38:29 +0000
In-Reply-To: <54AEB5690200007800052BF1@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 08/01/15 15:50, Jan Beulich wrote:
> +        if ( !buf )
> +            buf = p_data;
> +        else
> +            switch ( bytes_per_rep )
> +            {
> +#define CASE(bits, suffix)                                      \
> +            case (bits) / 8:                                    \
> +                asm ( "rep stos" #suffix                        \
> +                      :: "a" (*(const uint##bits##_t *)p_data), \
> +                         "D" (buf), "c" (*reps)                 \
> +                      : "memory" );                             \

This looks as if it needs output clobbers for D and c

~Andrew