From: Stephen Boyd <sboyd@codeaurora.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Mike Turquette <mturquette@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] clk: Add clk_unregister_{divider,gate,mux} to close memory leak
Date: Thu, 08 Jan 2015 13:22:42 -0800 [thread overview]
Message-ID: <54AEF522.1060904@codeaurora.org> (raw)
In-Reply-To: <1420451561-12360-1-git-send-email-k.kozlowski@samsung.com>
On 01/05/2015 01:52 AM, Krzysztof Kozlowski wrote:
> The common clk_register_{divider,gate,mux} functions allocated memory
> for internal data which wasn't freed anywhere. Drivers using these
> helpers could only unregister clocks but the memory would still leak.
>
> Add corresponding unregister functions which will release all resources.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
We're trying to move away from struct clk in provider APIs. It would be
nice to have these functions take the clk_hw pointer instead, but I
guess that can come later.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: Add clk_unregister_{divider,gate,mux} to close memory leak
Date: Thu, 08 Jan 2015 13:22:42 -0800 [thread overview]
Message-ID: <54AEF522.1060904@codeaurora.org> (raw)
In-Reply-To: <1420451561-12360-1-git-send-email-k.kozlowski@samsung.com>
On 01/05/2015 01:52 AM, Krzysztof Kozlowski wrote:
> The common clk_register_{divider,gate,mux} functions allocated memory
> for internal data which wasn't freed anywhere. Drivers using these
> helpers could only unregister clocks but the memory would still leak.
>
> Add corresponding unregister functions which will release all resources.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
We're trying to move away from struct clk in provider APIs. It would be
nice to have these functions take the clk_hw pointer instead, but I
guess that can come later.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-01-08 21:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 9:52 [PATCH 1/2] clk: Add clk_unregister_{divider,gate,mux} to close memory leak Krzysztof Kozlowski
2015-01-05 9:52 ` [PATCH 1/2] clk: Add clk_unregister_{divider, gate, mux} " Krzysztof Kozlowski
2015-01-05 9:52 ` [PATCH 2/2] clk: exynos-audss: Fix memory leak on driver unbind or probe failure Krzysztof Kozlowski
2015-01-05 9:52 ` Krzysztof Kozlowski
2015-01-08 21:23 ` Stephen Boyd
2015-01-08 21:23 ` Stephen Boyd
2015-01-14 22:25 ` Mike Turquette
2015-01-14 22:25 ` Mike Turquette
2015-01-15 8:14 ` Krzysztof Kozlowski
2015-01-15 8:14 ` Krzysztof Kozlowski
2015-01-08 21:22 ` Stephen Boyd [this message]
2015-01-08 21:22 ` [PATCH 1/2] clk: Add clk_unregister_{divider,gate,mux} to close memory leak Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AEF522.1060904@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.