All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Patrick Titiano <ptitiano@baylibre.com>,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: (ina2xx) implement update_interval attribute for ina226
Date: Fri, 09 Jan 2015 04:32:51 +0000	[thread overview]
Message-ID: <54AF59F3.9080200@roeck-us.net> (raw)
In-Reply-To: <CAMpxmJVmyVr7PJGaAkujacpWyRXew=37bz-PsURf7_-dTptBSw@mail.gmail.com>

On 01/08/2015 10:14 AM, Bartosz Golaszewski wrote:
> 2015-01-08 18:05 GMT+01:00 Guenter Roeck <linux@roeck-us.net>:
>> What is the purpose of multiplying the calculated average by 2 ?
>
> The comment above says:
>
>> +     /*
>> +      * Add bus and shunt voltage conversion times and multiple them
>> +      * by the averaging rate. Return the result in milliseconds.
>> +      */
>
> Since both conversion times are the same and equal
> INA226_CONV_TIME_DEFAULT I just multiplied it by 2 - I thought it was
> clear enough. I'll fix that in the next iteration.
>

Sorry, still don't get it. I must be a bit slow today ;-)

Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Patrick Titiano <ptitiano@baylibre.com>,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH] hwmon: (ina2xx) implement update_interval attribute for ina226
Date: Thu, 08 Jan 2015 20:32:51 -0800	[thread overview]
Message-ID: <54AF59F3.9080200@roeck-us.net> (raw)
In-Reply-To: <CAMpxmJVmyVr7PJGaAkujacpWyRXew=37bz-PsURf7_-dTptBSw@mail.gmail.com>

On 01/08/2015 10:14 AM, Bartosz Golaszewski wrote:
> 2015-01-08 18:05 GMT+01:00 Guenter Roeck <linux@roeck-us.net>:
>> What is the purpose of multiplying the calculated average by 2 ?
>
> The comment above says:
>
>> +     /*
>> +      * Add bus and shunt voltage conversion times and multiple them
>> +      * by the averaging rate. Return the result in milliseconds.
>> +      */
>
> Since both conversion times are the same and equal
> INA226_CONV_TIME_DEFAULT I just multiplied it by 2 - I thought it was
> clear enough. I'll fix that in the next iteration.
>

Sorry, still don't get it. I must be a bit slow today ;-)

Guenter



  reply	other threads:[~2015-01-09  4:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 16:25 [lm-sensors] [PATCH] hwmon: (ina2xx) implement update_interval attribute for ina226 Bartosz Golaszewski
2015-01-08 16:25 ` Bartosz Golaszewski
2015-01-08 17:05 ` [lm-sensors] " Guenter Roeck
2015-01-08 17:05   ` Guenter Roeck
2015-01-08 18:14   ` [lm-sensors] " Bartosz Golaszewski
2015-01-08 18:14     ` Bartosz Golaszewski
2015-01-09  4:32     ` Guenter Roeck [this message]
2015-01-09  4:32       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AF59F3.9080200@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=bcousson@baylibre.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=ptitiano@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.