From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangnan0@huawei.com (Wang Nan) Date: Fri, 9 Jan 2015 17:50:05 +0800 Subject: [PATCH v20 01/11] ARM: probes: move all probe code to dedicate directory In-Reply-To: <1420796864.4160.6.camel@linaro.org> References: <1420457350-77053-1-git-send-email-wangnan0@huawei.com> <1420769989-29208-1-git-send-email-wangnan0@huawei.com> <1420796864.4160.6.camel@linaro.org> Message-ID: <54AFA44D.1080500@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/1/9 17:47, Jon Medhurst (Tixy) wrote: > On Fri, 2015-01-09 at 10:19 +0800, Wang Nan wrote: >> In discussion on LKML (https://lkml.org/lkml/2014/11/28/158), Russell >> King suggests to move all probe related code to arch/arm/probes. This >> patch does the work. Due to dependency on 'arch/arm/kernel/patch.h', this >> patch also moves patch.h to 'arch/arm/include/asm/patch.h', and related >> '#include' directives are also midified to '#include '. >> >> Following is an overview of this patch: >> >> ./arch/arm/kernel/ ./arch/arm/probes/ >> |-- Makefile |-- Makefile >> |-- probes-arm.c ==> |-- decode-arm.c >> |-- probes-arm.h ==> |-- decode-arm.h >> |-- probes-thumb.c ==> |-- decode-thumb.c >> |-- probes-thumb.h ==> |-- decode-thumb.h >> |-- probes.c ==> |-- decode.c >> |-- probes.h ==> |-- decode.h >> | |-- kprobes >> | | |-- Makefile >> |-- kprobes-arm.c ==> | |-- actions-arm.c >> |-- kprobes-common.c ==> | |-- actions-common.c >> |-- kprobes-thumb.c ==> | |-- actions-thumb.c >> |-- kprobes.c ==> | |-- core.c >> |-- kprobes.h ==> | |-- core.h >> |-- kprobes-test-arm.c ==> | |-- test-arm.c >> |-- kprobes-test.c ==> | |-- test-core.c >> |-- kprobes-test.h ==> | |-- test-core.h >> |-- kprobes-test-thumb.c ==> | `-- test-thumb.c >> | `-- uprobes >> | |-- Makefile >> |-- uprobes-arm.c ==> |-- actions-arm.c >> |-- uprobes.c ==> |-- core.c >> |-- uprobes.h ==> `-- core.h >> | >> `-- patch.h ==> arch/arm/include/asm/patch.h >> >> Signed-off-by: Wang Nan >> Acked-by: Masami Hiramatsu >> --- > > Might have been good to mention what's changed in this version, I worked > out its kgdb.c, comments below... > > [...] > >> diff --git a/arch/arm/kernel/kgdb.c b/arch/arm/kernel/kgdb.c >> index 07db2f8..f3eb83f 100644 >> --- a/arch/arm/kernel/kgdb.c >> +++ b/arch/arm/kernel/kgdb.c >> @@ -16,7 +16,7 @@ >> >> #include >> >> -#include "patch.h" >> +#include > > To keep alphabetical ordering of headers this should be above the > #include > > Don't bother resending the patch, I'll just update the patch in the git > branch I'm putting together. > Thanks a lot! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932519AbbAIJu3 (ORCPT ); Fri, 9 Jan 2015 04:50:29 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:17661 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932455AbbAIJu1 (ORCPT ); Fri, 9 Jan 2015 04:50:27 -0500 Message-ID: <54AFA44D.1080500@huawei.com> Date: Fri, 9 Jan 2015 17:50:05 +0800 From: Wang Nan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: "Jon Medhurst (Tixy)" CC: , , , , , Li Zefan Subject: Re: [PATCH v20 01/11] ARM: probes: move all probe code to dedicate directory References: <1420457350-77053-1-git-send-email-wangnan0@huawei.com> <1420769989-29208-1-git-send-email-wangnan0@huawei.com> <1420796864.4160.6.camel@linaro.org> In-Reply-To: <1420796864.4160.6.camel@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.69.90] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.54AFA476.00B1,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d2b419d0aeccd164ff2a28d9c52e46f9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/1/9 17:47, Jon Medhurst (Tixy) wrote: > On Fri, 2015-01-09 at 10:19 +0800, Wang Nan wrote: >> In discussion on LKML (https://lkml.org/lkml/2014/11/28/158), Russell >> King suggests to move all probe related code to arch/arm/probes. This >> patch does the work. Due to dependency on 'arch/arm/kernel/patch.h', this >> patch also moves patch.h to 'arch/arm/include/asm/patch.h', and related >> '#include' directives are also midified to '#include '. >> >> Following is an overview of this patch: >> >> ./arch/arm/kernel/ ./arch/arm/probes/ >> |-- Makefile |-- Makefile >> |-- probes-arm.c ==> |-- decode-arm.c >> |-- probes-arm.h ==> |-- decode-arm.h >> |-- probes-thumb.c ==> |-- decode-thumb.c >> |-- probes-thumb.h ==> |-- decode-thumb.h >> |-- probes.c ==> |-- decode.c >> |-- probes.h ==> |-- decode.h >> | |-- kprobes >> | | |-- Makefile >> |-- kprobes-arm.c ==> | |-- actions-arm.c >> |-- kprobes-common.c ==> | |-- actions-common.c >> |-- kprobes-thumb.c ==> | |-- actions-thumb.c >> |-- kprobes.c ==> | |-- core.c >> |-- kprobes.h ==> | |-- core.h >> |-- kprobes-test-arm.c ==> | |-- test-arm.c >> |-- kprobes-test.c ==> | |-- test-core.c >> |-- kprobes-test.h ==> | |-- test-core.h >> |-- kprobes-test-thumb.c ==> | `-- test-thumb.c >> | `-- uprobes >> | |-- Makefile >> |-- uprobes-arm.c ==> |-- actions-arm.c >> |-- uprobes.c ==> |-- core.c >> |-- uprobes.h ==> `-- core.h >> | >> `-- patch.h ==> arch/arm/include/asm/patch.h >> >> Signed-off-by: Wang Nan >> Acked-by: Masami Hiramatsu >> --- > > Might have been good to mention what's changed in this version, I worked > out its kgdb.c, comments below... > > [...] > >> diff --git a/arch/arm/kernel/kgdb.c b/arch/arm/kernel/kgdb.c >> index 07db2f8..f3eb83f 100644 >> --- a/arch/arm/kernel/kgdb.c >> +++ b/arch/arm/kernel/kgdb.c >> @@ -16,7 +16,7 @@ >> >> #include >> >> -#include "patch.h" >> +#include > > To keep alphabetical ordering of headers this should be above the > #include > > Don't bother resending the patch, I'll just update the patch in the git > branch I'm putting together. > Thanks a lot!