From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60187)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Y9Wz2-0005DI-HU
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 05:40:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Y9Wyx-0004XS-I8
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 05:40:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47447)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Y9Wyx-0004XN-Ar
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 05:39:55 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t09AdsDI027790
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Fri, 9 Jan 2015 05:39:54 -0500
Message-ID: <54AFAFF6.8060306@redhat.com>
Date: Fri, 09 Jan 2015 11:39:50 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1420711408-15766-1-git-send-email-pbonzini@redhat.com>
	<1420711408-15766-3-git-send-email-pbonzini@redhat.com>
	<20150109021924.GB6087@fam-t430.nay.redhat.com>
In-Reply-To: <20150109021924.GB6087@fam-t430.nay.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] qemu-timer: add timer_init and
	timer_init_ns/us/ms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org



On 09/01/2015 03:19, Fam Zheng wrote:
>> >  /**
>> > + * timer_init:
>> > + * @clock: the clock to associate with the timer
> s/@clock/@type/
> 
> And similarly below.

Doh, cut-and-paste error (it's also in timer_new and friends).

>> > + * @scale: the scale value for the timer
>> > + * @cb: the callback to call when the timer expires
>> > + * @opaque: the opaque pointer to pass to the callback
>> > + *
>> > + * Create a new timer with the given scale on the default timer list
> s/Create a new/Initialize a/ ?
> 
> And similarly below.

Good idea, thanks!

Paolo