From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion Date: Fri, 09 Jan 2015 13:17:53 +0200 Message-ID: <54AFB8E1.10903@dev.mellanox.co.il> References: <54AD5DDD.2090808@dev.mellanox.co.il> <54AD6563.4040603@suse.de> <54ADA777.6090801@cs.wisc.edu> <54AE36CE.8020509@acm.org> <1420755361.2842.16.camel@haakon3.risingtidesystems.com> <1420756142.11310.9.camel@HansenPartnership.com> <1420757822.2842.39.camel@haakon3.risingtidesystems.com> <54AF122C.9070703@cs.wisc.edu> Reply-To: open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: In-Reply-To: <54AF122C.9070703-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Mike Christie , "Nicholas A. Bellinger" Cc: James Bottomley , Bart Van Assche , open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Hannes Reinecke , lsf-pc-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-scsi , target-devel List-Id: linux-scsi@vger.kernel.org On 1/9/2015 1:26 AM, Mike Christie wrote: > I am not sure if we want this to be a deciding factor. I think the > session wide lock is something that can be removed in the main IO paths. > > A lot of what it is used for now is cmd/task related handling like list > accesses. When we have the scsi layer alloc/free/manage that, then we > can simplify that a lot for iser/bnx2i/cxgb*i since there send path is > less complicated than software iscsi. > Completely agree. We should assume that other than session-wide command sequence numbers nothing is synced across connections. > It is also used for the state check but I think that is overkill. > I have a piped patch to remove this completely redundant spin_lock that protects a check on a state that can change right after the spin_unlock. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.