All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Egger, Christoph" <chegger@amazon.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: Julien Grall <julien.grall@linaro.org>,
	Keir Fraser <keir@xen.org>, Matt Wilson <msw@amazon.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v3 1/2] gnttab: Introduce rwlock to protect updates to grant table state
Date: Fri, 9 Jan 2015 14:05:13 +0100	[thread overview]
Message-ID: <54AFD209.70209@amazon.de> (raw)
In-Reply-To: <5492CA7502000078000508E8@mail.emea.novell.com>

On 2014/12/18 12:37, Jan Beulich wrote:
>>>> On 03.12.14 at 15:29, <chegger@amazon.de> wrote:
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
[...]
>> @@ -944,6 +944,7 @@ __gnttab_unmap_common(
>>      }
>>  
>>      op->rd = rd;
>> +    read_lock(&rgt->lock);
>>      act = &active_entry(rgt, op->map->ref);
>>  
>>      if ( op->frame == 0 )
> 
> The nesting of the two locks should be mentioned in the doc change.

Where do you see the nesting coming from?

Christoph

  reply	other threads:[~2015-01-09 13:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03 14:29 [PATCH v3 0/2] gnttab: Improve scaleability Christoph Egger
2014-12-03 14:29 ` [PATCH v3 1/2] gnttab: Introduce rwlock to protect updates to grant table state Christoph Egger
2014-12-18 11:37   ` Jan Beulich
2015-01-09 13:05     ` Egger, Christoph [this message]
2015-01-09 14:10       ` Jan Beulich
2015-01-09 14:54         ` Egger, Christoph
2014-12-03 14:29 ` [PATCH v3 2/2] gnttab: refactor locking for scalability Christoph Egger
2014-12-18 12:51   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AFD209.70209@amazon.de \
    --to=chegger@amazon.de \
    --cc=JBeulich@suse.com \
    --cc=julien.grall@linaro.org \
    --cc=keir@xen.org \
    --cc=msw@amazon.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.