From: Eric Blake <eblake@redhat.com>
To: Don Slutz <dslutz@verizon.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION
Date: Fri, 09 Jan 2015 09:21:36 -0700 [thread overview]
Message-ID: <54B00010.8030607@redhat.com> (raw)
In-Reply-To: <1420816655-14775-2-git-send-email-dslutz@verizon.com>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On 01/09/2015 08:17 AM, Don Slutz wrote:
> This is the same way vl.c handles this.
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 7876258..b6e9220 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -35,7 +35,7 @@
> #include "block/qapi.h"
> #include <getopt.h>
>
> -#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION \
> +#define QEMU_IMG_VERSION "qemu-img version " QEMU_VERSION QEMU_PKGVERSION \
> ", Copyright (c) 2004-2008 Fabrice Bellard\n"
>
> typedef struct img_cmd_t {
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-01-09 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 15:17 [Qemu-devel] [PATCH v2 0/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION (was qemu-img: Add --pkgversion common option) Don Slutz
2015-01-09 15:17 ` [Qemu-devel] [PATCH v2 1/1] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION Don Slutz
2015-01-09 16:21 ` Eric Blake [this message]
2015-01-28 19:51 ` Don Slutz
2015-02-02 13:55 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B00010.8030607@redhat.com \
--to=eblake@redhat.com \
--cc=dslutz@verizon.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.